Delete the PPAPI example plugin.

Remove the PPAPI example plugin.

Lots of the code was wrong and messy, and we now have a separate directory of examples.

BUG=54004
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144972

[nfullagar, 2012-06-28 22:29:32]

A few nits, otherwise agreed the smaller example is much better than what it was
before.

https://chromiumcodereview.appspot.com/10697022/diff/1/ppapi/example/example.cc
File ppapi/example/example.cc (right):

https://chromiumcodereview.appspot.com/10697022/diff/1/ppapi/example/example....
ppapi/example/example.cc:19: static const int kStepsPerCircle = 800;
this const could be moved down to where it is actually used.

https://chromiumcodereview.appspot.com/10697022/diff/1/ppapi/example/example....
ppapi/example/example.cc:29: *image->GetAddr32(pp::Point(x, y)) = color;
nit: not sure if the compiler is going to opt this, but I would usually hoist
the GetAddr32() address calc out of the inner loop, and have the inner loop do
*addr32++ = color;
(At the least, debug non-opt builds tend to run a bit faster.)

https://chromiumcodereview.appspot.com/10697022/diff/1/ppapi/example/example....
ppapi/example/example.cc:55: virtual bool HandleInputEvent(const pp::InputEvent&
event) {
Would be nice to have this function do something more interactive.

https://chromiumcodereview.appspot.com/10697022/diff/1/ppapi/example/example....
ppapi/example/example.cc:70: pp::Size(width, height), false);
would be helpful if the ownership of 'image' was a bit more explicit (see note
below.)  Not super keen on returning a copy of the local instance - imho it
feels cleaner if the caller passed down an instance instead of passing it up
from here.

https://chromiumcodereview.appspot.com/10697022/diff/1/ppapi/example/example....
ppapi/example/example.cc:74: // Fill with semitransparent gradient.
This could be a separate function, FillRectWithGradient(...)

https://chromiumcodereview.appspot.com/10697022/diff/1/ppapi/example/example....
ppapi/example/example.cc:76: char* row = &static_cast<char*>(image.data())[y *
image.stride()];
and this could use row = GetAddr32(...) instead

https://chromiumcodereview.appspot.com/10697022/diff/1/ppapi/example/example....
ppapi/example/example.cc:81: row[x * 4 + 3] = y;
*row++ = color;

https://chromiumcodereview.appspot.com/10697022/diff/1/ppapi/example/example....
ppapi/example/example.cc:87: 2 * 3.14159265358979F;
const for Pi?

https://chromiumcodereview.appspot.com/10697022/diff/1/ppapi/example/example....
ppapi/example/example.cc:93: const uint32_t box_bgra = 0x80000000;  // Alpha
50%.
todo: should ppapi/cpp have an inline helper to construct colors instead of code
using hex constants like this (which are easy to mess up the color channel
ordering.  for example, the gradient code above could use it.)

https://chromiumcodereview.appspot.com/10697022/diff/1/ppapi/example/example....
ppapi/example/example.cc:99: pp::ImageData image = PaintImage(width_, height_);
see note above about tracing ownership of 'image'

https://chromiumcodereview.appspot.com/10697022/diff/1/ppapi/example/example....
ppapi/example/example.cc:120: void OnFlush(int32_t result) {
check result parameter and log errors?

[brettw, 2012-06-28 23:43:29]

If we're going to be doing more significant cleanup and optimization, I'd rather
just delete this thing, which is what this patch does.

[brettw, 2012-06-28 23:44:25]

git cl got a bit confused and didn't put a "D" next to some of the files. But
they're deleted.

[nfullagar, 2012-06-28 23:54:37]

sgtm, couple of fixes otherwise lgtm

https://chromiumcodereview.appspot.com/10697022/diff/8001/ppapi/examples/2d/2...
File ppapi/examples/2d/2d.html (right):

https://chromiumcodereview.appspot.com/10697022/diff/8001/ppapi/examples/2d/2...
ppapi/examples/2d/2d.html:4: Copyright (c) 2011 The Chromium Authors. All rights
reserved.
2012

https://chromiumcodereview.appspot.com/10697022/diff/8001/ppapi/examples/2d/2...
ppapi/examples/2d/2d.html:9: <title>Audio Example</title>
2d example?

https://chromiumcodereview.appspot.com/10697022/diff/8001/ppapi/examples/2d/2...
ppapi/examples/2d/2d.html:14: <!-- Unsupported sample rates will cause the
plugin to fail to load. -->
sample rates?