src/handles.cc - Issue 10697015: Separating transitions from descriptors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/handles.cc

Issue 10697015: Separating transitions from descriptors. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressing Michaels comments. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/handles.cc

diff --git a/src/handles.cc b/src/handles.cc

index 1962e2f651b1a11cf11f5cf4fb187aabaddfa612..946c1008aae1975ce143aaaee9c2cbb3c0f88b6e 100644

--- a/src/handles.cc

+++ b/src/handles.cc

@@ -729,7 +729,7 @@ Handle<FixedArray> GetEnumPropertyKeys(Handle<JSObject> object,

Handle<DescriptorArray>(object->map()->instance_descriptors(), isolate);

for (int i = 0; i < descs->number_of_descriptors(); i++) {

- if (descs->IsProperty(i) && !descs->GetDetails(i).IsDontEnum()) {

+ if (!descs->GetDetails(i).IsDontEnum()) {

storage->set(index, descs->GetKey(i));

PropertyDetails details = descs->GetDetails(i);

sort_array->set(index, Smi::FromInt(details.index()));

« no previous file with comments | « src/factory.cc ('k') | src/hydrogen.cc » ('j') | src/transitions-inl.h » ('J')