Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/profile-generator.cc

Issue 10697015: Separating transitions from descriptors. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Using WhitenessWitness in TransitionArray code. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects-printer.cc ('k') | src/property.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2200 matching lines...) Expand 10 before | Expand all | Expand 10 after
2211 if (Object* setter = accessors->setter()) { 2211 if (Object* setter = accessors->setter()) {
2212 SetPropertyReference(js_obj, entry, descs->GetKey(i), 2212 SetPropertyReference(js_obj, entry, descs->GetKey(i),
2213 setter, "set-%s"); 2213 setter, "set-%s");
2214 } 2214 }
2215 } 2215 }
2216 break; 2216 break;
2217 } 2217 }
2218 case NORMAL: // only in slow mode 2218 case NORMAL: // only in slow mode
2219 case HANDLER: // only in lookup results, not in descriptors 2219 case HANDLER: // only in lookup results, not in descriptors
2220 case INTERCEPTOR: // only in lookup results, not in descriptors 2220 case INTERCEPTOR: // only in lookup results, not in descriptors
2221 case MAP_TRANSITION: // we do not care about transitions here...
2222 case CONSTANT_TRANSITION:
2223 break; 2221 break;
2222 case TRANSITION:
2224 case NONEXISTENT: 2223 case NONEXISTENT:
2225 UNREACHABLE(); 2224 UNREACHABLE();
2226 break; 2225 break;
2227 } 2226 }
2228 } 2227 }
2229 } else { 2228 } else {
2230 StringDictionary* dictionary = js_obj->property_dictionary(); 2229 StringDictionary* dictionary = js_obj->property_dictionary();
2231 int length = dictionary->Capacity(); 2230 int length = dictionary->Capacity();
2232 for (int i = 0; i < length; ++i) { 2231 for (int i = 0; i < length; ++i) {
2233 Object* k = dictionary->KeyAt(i); 2232 Object* k = dictionary->KeyAt(i);
(...skipping 1329 matching lines...) Expand 10 before | Expand all | Expand 10 after
3563 3562
3564 3563
3565 void HeapSnapshotJSONSerializer::SortHashMap( 3564 void HeapSnapshotJSONSerializer::SortHashMap(
3566 HashMap* map, List<HashMap::Entry*>* sorted_entries) { 3565 HashMap* map, List<HashMap::Entry*>* sorted_entries) {
3567 for (HashMap::Entry* p = map->Start(); p != NULL; p = map->Next(p)) 3566 for (HashMap::Entry* p = map->Start(); p != NULL; p = map->Next(p))
3568 sorted_entries->Add(p); 3567 sorted_entries->Add(p);
3569 sorted_entries->Sort(SortUsingEntryValue); 3568 sorted_entries->Sort(SortUsingEntryValue);
3570 } 3569 }
3571 3570
3572 } } // namespace v8::internal 3571 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects-printer.cc ('k') | src/property.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698