Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: src/bootstrapper.cc

Issue 10697015: Separating transitions from descriptors. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Using WhitenessWitness in TransitionArray code. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ast.cc ('k') | src/factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2173 matching lines...) Expand 10 before | Expand all | Expand 10 after
2184 HandleScope inner; 2184 HandleScope inner;
2185 ASSERT(!to->HasFastProperties()); 2185 ASSERT(!to->HasFastProperties());
2186 // Add to dictionary. 2186 // Add to dictionary.
2187 Handle<String> key = Handle<String>(descs->GetKey(i)); 2187 Handle<String> key = Handle<String>(descs->GetKey(i));
2188 Handle<Object> callbacks(descs->GetCallbacksObject(i)); 2188 Handle<Object> callbacks(descs->GetCallbacksObject(i));
2189 PropertyDetails d = 2189 PropertyDetails d =
2190 PropertyDetails(details.attributes(), CALLBACKS, details.index()); 2190 PropertyDetails(details.attributes(), CALLBACKS, details.index());
2191 JSObject::SetNormalizedProperty(to, key, callbacks, d); 2191 JSObject::SetNormalizedProperty(to, key, callbacks, d);
2192 break; 2192 break;
2193 } 2193 }
2194 case MAP_TRANSITION:
2195 case CONSTANT_TRANSITION:
2196 // Ignore non-properties.
2197 break;
2198 case NORMAL: 2194 case NORMAL:
2199 // Do not occur since the from object has fast properties. 2195 // Do not occur since the from object has fast properties.
2200 case HANDLER: 2196 case HANDLER:
2201 case INTERCEPTOR: 2197 case INTERCEPTOR:
2198 case TRANSITION:
2202 case NONEXISTENT: 2199 case NONEXISTENT:
2203 // No element in instance descriptors have proxy or interceptor type. 2200 // No element in instance descriptors have proxy or interceptor type.
2204 UNREACHABLE(); 2201 UNREACHABLE();
2205 break; 2202 break;
2206 } 2203 }
2207 } 2204 }
2208 } else { 2205 } else {
2209 Handle<StringDictionary> properties = 2206 Handle<StringDictionary> properties =
2210 Handle<StringDictionary>(from->property_dictionary()); 2207 Handle<StringDictionary>(from->property_dictionary());
2211 int capacity = properties->Capacity(); 2208 int capacity = properties->Capacity();
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
2362 return from + sizeof(NestingCounterType); 2359 return from + sizeof(NestingCounterType);
2363 } 2360 }
2364 2361
2365 2362
2366 // Called when the top-level V8 mutex is destroyed. 2363 // Called when the top-level V8 mutex is destroyed.
2367 void Bootstrapper::FreeThreadResources() { 2364 void Bootstrapper::FreeThreadResources() {
2368 ASSERT(!IsActive()); 2365 ASSERT(!IsActive());
2369 } 2366 }
2370 2367
2371 } } // namespace v8::internal 2368 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ast.cc ('k') | src/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698