chrome/browser/ui/webui/web_dialog_web_contents_delegate.h - Issue 10696222: Make chrome::Navigate take in a Browser* that is never NULL. That function doesn't have a context, …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/web_dialog_web_contents_delegate.h

Issue 10696222: Make chrome::Navigate take in a Browser* that is never NULL. That function doesn't have a context, … (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: sync Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/intents/web_intent_picker_controller.cc ('k') | chrome/browser/ui/webui/web_dialog_web_contents_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/web_dialog_web_contents_delegate.h

===================================================================

--- chrome/browser/ui/webui/web_dialog_web_contents_delegate.h (revision 146674)

+++ chrome/browser/ui/webui/web_dialog_web_contents_delegate.h (working copy)

@@ -18,11 +18,11 @@

// behave consistently.

class WebDialogWebContentsDelegate : public content::WebContentsDelegate {

public:

- // Opens a new URL inside |source| (if source is NULL open in the current

- // front-most tab). |profile| is the profile that the browser should be owened

- // by. |params| contains the URL to open and various attributes such as

- // disposition. On return |out_new_contents| contains the WebContents the

- // URL is opened in. Returns the browser spawned by the operation.

+ // Opens a new URL inside |source|. |profile| is the profile that the browser

+ // should be owned by. |params| contains the URL to open and various

+ // attributes such as disposition. On return |out_new_contents| contains the

+ // WebContents the URL is opened in. Returns the browser spawned by the

+ // operation.

static Browser* StaticOpenURLFromTab(Profile* profile,

content::WebContents* source,

const content::OpenURLParams& params,