Implement SyncSocket for untrusted NaCl builds.

Implement SyncSocket for untrusted NaCl builds.
BUG=116317
TEST=manual
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146732

[bbudge, 2012-07-13 22:53:01]

This is enough implementation to get the audio proxy working. I'm not sure how
much more is needed (or possible in NaCl).

[brettw, 2012-07-13 23:12:55]

lgtm

http://codereview.chromium.org/10696217/diff/3001/base/sync_socket_nacl.cc
File base/sync_socket_nacl.cc (right):

http://codereview.chromium.org/10696217/diff/3001/base/sync_socket_nacl.cc#ne...
base/sync_socket_nacl.cc:32: if (handle_ != -1) {
Can you use kInvalidHandle instead of -1 in this function?

http://codereview.chromium.org/10696217/diff/3001/base/sync_socket_nacl.cc#ne...
base/sync_socket_nacl.cc:40: return -1;
Can you comment why this isn't implemented?

[Mark Seaborn, 2012-07-13 23:18:32]

http://codereview.chromium.org/10696217/diff/3001/base/sync_socket_nacl.cc
File base/sync_socket_nacl.cc (right):

http://codereview.chromium.org/10696217/diff/3001/base/sync_socket_nacl.cc#ne...
base/sync_socket_nacl.cc:33: close(handle_);
Please check the return value of close()

[bbudge, 2012-07-13 23:44:05]

http://codereview.chromium.org/10696217/diff/3001/base/sync_socket_nacl.cc
File base/sync_socket_nacl.cc (right):

http://codereview.chromium.org/10696217/diff/3001/base/sync_socket_nacl.cc#ne...
base/sync_socket_nacl.cc:32: if (handle_ != -1) {
On 2012/07/13 23:12:55, brettw wrote:
> Can you use kInvalidHandle instead of -1 in this function?

Done.

http://codereview.chromium.org/10696217/diff/3001/base/sync_socket_nacl.cc#ne...
base/sync_socket_nacl.cc:33: close(handle_);
On 2012/07/13 23:18:32, Mark Seaborn wrote:
> Please check the return value of close()

Done.

http://codereview.chromium.org/10696217/diff/3001/base/sync_socket_nacl.cc#ne...
base/sync_socket_nacl.cc:40: return -1;
On 2012/07/13 23:12:55, brettw wrote:
> Can you comment why this isn't implemented?

Done.