MutationObserver

lib/dom/templates/html/impl/impl_MutationObserver.darttemplate

Index: lib/dom/templates/html/impl/impl_MutationObserver.darttemplate
diff --git a/lib/dom/templates/html/impl/impl_MutationObserver.darttemplate b/lib/dom/templates/html/impl/impl_MutationObserver.darttemplate
new file mode 100644
index 0000000000000000000000000000000000000000..484e7d713b39fba38903f5193211d59c29ba2f00
--- /dev/null
+++ b/lib/dom/templates/html/impl/impl_MutationObserver.darttemplate
@@ -0,0 +1,80 @@
+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {
+$!MEMBERS
+  void observe(Node target,
+               [Map options,
+                bool childList,
+                bool attributes,
+                bool characterData,
+                bool subtree,
+                bool attributeOldValue,
+                bool characterDataOldValue,
+                List<String> attributeFilter]) {
+
+    // Parse options into map of known type.
+    var parsedOptions = _createDict();
+
+    if (options != null) {
+      options.forEach((k, v) {
+          if (_boolKeys.containsKey(k)) {

[Anton Muhin, 2012/07/13 10:50:47]

maybe simplify it too: if k != 'attributeFilter' ?

+            _add(parsedOptions, k, true === v);
+          } else if (k == 'attributeFilter') {
+            _add(parsedOptions, k, _fixupList(v));
+          } else {
+            throw new IllegalArgumentException(
+                "Illegal MutationObserver.observe option '$k'");
+          }
+        });
+    }
+
+    // Override options passed in the map with named optional arguments.
+    override(key, value) {
+      if (value != null) _add(parsedOptions, key, value);
+    }
+
+    override('childList', childList);

[Anton Muhin, 2012/07/13 10:50:47]

as another option:

override(key, value) {
  if (value != null) _add(parsedOptions, key, value);
  if (options !=null && options.containsKey(key)) _add(parsedOptions, key,
options[key]);
}

that will apparently render obsolete the whole loop above and _boolKeys stuff

[sra1, 2012/07/19 00:34:54]

When we get experience with a couple of these 'bag of options' APIs we might
look at generating them automatically.
I think longer term I want the (generated) code to be very simple so that a
compiler can tell that there is a big benefit to specializing these functions.
That is one reason to keep 'options != null' at the top level.

+    override('attributes', attributes);
+    override('characterData', characterData);
+    override('subtree', subtree);
+    override('attributeOldValue', attributeOldValue);
+    override('characterDataOldValue', characterDataOldValue);
+    if (attributeFilter != null) {
+      override('attributeFilter', _fixupList(attributeFilter));
+    }
+
+    _call(target, parsedOptions);
+  }
+
+   // TODO: Change to a set when const Sets are available.
+  static final _boolKeys =
+    const {'childList': true,
+           'attributes': true,
+           'characterData': true,
+           'subtree': true,
+           'attributeOldValue': true,
+           'characterDataOldValue': true };
+
+$if DARTIUM
+  static _createDict() => {};
+  static _add(Map m, String key, value) { m[key] = value; }
+  static _lookup(Map m, String key) => m[key];
+  static _fixupList(list) => list;
+
+  _call(Node target, options) {
+    _observe(target, options);
+  }
+$endif
+
+$if FROG
+  static _createDict() => JS('var', '{}');
+  static _add(Map m, String key, value) { JS('void', '#[#] = #', m, key, value); }
+  static _lookup(Map m, String key) => JS('var', '#[#]', m, key);
+  static _fixupList(list) => list;  // TODO: Ensure is a JavaScript Array.
+
+  // Call native function with no conversions.
+  _call(Node target, options) native 'observe';
+$endif
+}