Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 10696207: Merge 144583 - sync: fix reentrancy crash in ModelAssociationManager (Closed)

Created:
8 years, 5 months ago by Nicolas Zea
Modified:
8 years, 5 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Visibility:
Public.

Description

Merge 144583 - sync: fix reentrancy crash in ModelAssociationManager Don't call OnTypesLoaded unless we're IDLE, since we could be in the middle of some other process. Add a CHECK to ensure we don't re-enter ModelAssociationManager::Initialize. BUG=134550 TEST=trigger unrecoverable error with data type while data type configuration is in progress, don't crash. Review URL: https://chromiumcodereview.appspot.com/10687002 TBR=tim@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146446

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -10 lines) Patch
M chrome/browser/sync/glue/fake_data_type_controller.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/model_association_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/model_association_manager.cc View 1 2 6 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/sync/glue/model_association_manager_unittest.cc View 1 2 chunks +70 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Nicolas Zea
8 years, 5 months ago (2012-07-12 21:13:59 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698