Have iOS use the same atomicops_internal implementation that Mac uses.

Have iOS use the same atomicops_internal implementation that Mac uses.

The atomicops_internal file for Mac and iOS is not actually architecture-specific, so it is being renamd to be arch-independent.

BUG=b/6754112
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146584

[leng, 2012-07-12 12:29:56]

I left out the #pragma once that was in the bling version, because the chromium
style guide says not to use it.

[stuartmorgan, 2012-07-12 12:39:58]

I imagine we should add this header to base.gypi's sources list. Now that it has
the _mac ending it should be fine.

> I left out the #pragma once that was in the bling version, because the
> chromium style guide says not to use it.

Just don't touch that part of the guide; the ink is still wet :)

https://chromiumcodereview.appspot.com/10696193/diff/1/base/atomicops.h
File base/atomicops.h (right):

https://chromiumcodereview.appspot.com/10696193/diff/1/base/atomicops.h#newco...
base/atomicops.h:135: // so it is arch independent (And PPC isn't supported for
desktop builds).
Remove this whole comment; it no longer applies.

[stuartmorgan, 2012-07-12 12:40:23]

Oops, meant to say LGTM with those changes.

[leng, 2012-07-12 12:51:37]

I added atomicops_internal_mac.h to base.gypi, thank you for the reminder!

https://chromiumcodereview.appspot.com/10696193/diff/1/base/atomicops.h
File base/atomicops.h (right):

https://chromiumcodereview.appspot.com/10696193/diff/1/base/atomicops.h#newco...
base/atomicops.h:135: // so it is arch independent (And PPC isn't supported for
desktop builds).
On 2012/07/12 12:39:58, stuartmorgan wrote:
> Remove this whole comment; it no longer applies.

Done.

[Mark Mentovai, 2012-07-12 15:54:36]

https://chromiumcodereview.appspot.com/10696193/diff/6/base/atomicops_interna...
File base/atomicops_internals_mac.h (right):

https://chromiumcodereview.appspot.com/10696193/diff/6/base/atomicops_interna...
base/atomicops_internals_mac.h:7: #ifndef BASE_ATOMICOPS_INTERNALS_X86_MACOSX_H_
Fix. Also on lines 8 and 197.

[leng, 2012-07-13 08:05:49]

Thanks for catching that!
PTAL

https://chromiumcodereview.appspot.com/10696193/diff/6/base/atomicops_interna...
File base/atomicops_internals_mac.h (right):

https://chromiumcodereview.appspot.com/10696193/diff/6/base/atomicops_interna...
base/atomicops_internals_mac.h:7: #ifndef BASE_ATOMICOPS_INTERNALS_X86_MACOSX_H_
On 2012/07/12 15:54:36, Mark Mentovai wrote:
> Fix. Also on lines 8 and 197.

Done.

[Mark Mentovai, 2012-07-13 12:55:22]

LGTM

[commit-bot: I haz the power, 2012-07-13 13:09:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/leng@chromium.org/10696193/8002

[commit-bot: I haz the power, 2012-07-13 14:28:00]

Try job failure for 10696193-8002 (retry) on linux_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-07-13 14:33:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/leng@chromium.org/10696193/8002

[commit-bot: I haz the power, 2012-07-13 16:49:45]

Change committed as 146584