lib/compiler/implementation/tree/nodes.dart - Issue 10696192: Transform (x && y) && z into x && (y && z).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/tree/nodes.dart

Issue 10696192: Transform (x && y) && z into x && (y && z). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/compiler/implementation/tree/nodes.dart

diff --git a/lib/compiler/implementation/tree/nodes.dart b/lib/compiler/implementation/tree/nodes.dart

index 52c99bb6e2befd109526249dba6f539859680584..1e356539a9434db3c0ed19a13c0affec3fb8bd34 100644

--- a/lib/compiler/implementation/tree/nodes.dart

+++ b/lib/compiler/implementation/tree/nodes.dart

@@ -282,9 +282,13 @@ class Send extends Expression {

bool get isFunctionObjectInvocation() => selector === null;

bool get isPrefix() => argumentsNode is Prefix;

bool get isPostfix() => argumentsNode is Postfix;

+ bool get isCall() => !isOperator && !isPropertyAccess;

bool get isIndex() =>

isOperator && selector.asOperator().source.stringValue === '[]';

- bool get isCall() => !isOperator && !isPropertyAccess;

+ bool get isLogicalAnd() =>

+ isOperator && selector.asOperator().source.stringValue === '&&';

+ bool get isLogicalOr() =>

+ isOperator && selector.asOperator().source.stringValue === '||';

Token getBeginToken() {

if (isPrefix && !isIndex) return selector.getBeginToken();