Issue 10696190: Split gdata_file_system_interface.h from gdata_file_system.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10696190: Split gdata_file_system_interface.h from gdata_file_system.h (Closed)

Created:
8 years, 5 months ago by kochi

Modified:
8 years, 5 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, achuith+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, satorux1, Daniel Erat

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Split gdata_file_system_interface.h from gdata_file_system.h Now mock_gdata_file_system includes gdata_file_system_interface.h. This is for preparing another filesystem using the file system interface. gdata_file_system_interface.h is extracted from gdata_file_system.h, and removed the following unused callback typedefs: - GetJsonDocumentCallback - GetDocumentResourceIdCallback BUG=chromium:127728 TEST=compile, all tests run Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146302

Patch Set 1 : . #

Patch Set 2 : . #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+378 lines, -360 lines)			Patch
M	chrome/browser/chromeos/extensions/file_manager_util.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.h	View		2 chunks	+1 line, -354 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
A	chrome/browser/chromeos/gdata/gdata_file_system_interface.h	View	1	1 chunk	+367 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_system_service.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_system_service.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/mock_gdata_file_system.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

8 years, 5 months ago (2012-07-12 08:55:15 UTC) #3

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kochi@chromium.org/10696190/11

Expand Messages | Collapse Messages