Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 10696187: Make wow_helper.sln pure ASCII (Closed)

Created:
8 years, 5 months ago by jln (very slow on Chromium)
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Make wow_helper.sln pure ASCII Non 7-bit ASCII characters confused the hell out of try bots and scripts and led to hard to track bugs. BUG= TEST= NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146270

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sandbox/wow_helper.sln View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jln (very slow on Chromium)
Make wow_helper.sln 7-bit ascii clean.
8 years, 5 months ago (2012-07-12 00:41:46 UTC) #1
jln (very slow on Chromium)
Trivial CL to fix a hard to track bug.
8 years, 5 months ago (2012-07-12 00:42:08 UTC) #2
jschuh
lgtm
8 years, 5 months ago (2012-07-12 02:08:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/10696187/1
8 years, 5 months ago (2012-07-12 02:08:22 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 02:08:50 UTC) #5
Change committed as 146270

Powered by Google App Engine
This is Rietveld 408576698