Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 10696185: Use GenericScopedHandle to implement ScopedCreateDC. (Closed)

Created:
8 years, 5 months ago by Wez
Modified:
8 years, 5 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Use GenericScopedHandle to implement ScopedCreateDC. TEST=Existing unit-tests, Chrome runs, everybody happy. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146457

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -24 lines) Patch
M base/win/scoped_hdc.h View 2 chunks +12 lines, -24 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
Wez
PTAL
8 years, 5 months ago (2012-07-12 00:32:36 UTC) #1
alexeypa (please no reviews)
lgtm https://chromiumcodereview.appspot.com/10696185/diff/1/base/win/scoped_hdc.h File base/win/scoped_hdc.h (left): https://chromiumcodereview.appspot.com/10696185/diff/1/base/win/scoped_hdc.h#oldcode73 base/win/scoped_hdc.h:73: #ifdef NOGDI This code was wrong BTW. When ...
8 years, 5 months ago (2012-07-12 18:18:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10696185/1
8 years, 5 months ago (2012-07-12 18:40:09 UTC) #3
commit-bot: I haz the power
Presubmit check for 10696185-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-12 18:40:12 UTC) #4
Wez
brettw@, can you rubber-stamp?
8 years, 5 months ago (2012-07-12 20:26:29 UTC) #5
brettw
lgtm
8 years, 5 months ago (2012-07-12 20:28:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10696185/1
8 years, 5 months ago (2012-07-12 20:29:30 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 22:03:58 UTC) #8
Change committed as 146457

Powered by Google App Engine
This is Rietveld 408576698