Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issue 10696181: Added unit test for ServiceProcessPrefs (Closed)

Created:
8 years, 5 months ago by Mehrdad
Modified:
8 years, 5 months ago
Reviewers:
Albert Bodenhamer
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Added unit test for ServiceProcessPrefs Just added a unit test to ServiceProcessPrefs. TEST=ServiceProcessPrefsTest.RetrievePrefs Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146400

Patch Set 1 #

Patch Set 2 : Updated the copyright year #

Patch Set 3 : Added newline at EOF #

Total comments: 1

Patch Set 4 : Added some #include's and removed others #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/service/service_process_prefs_unittest.cc View 1 2 3 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mehrdad
8 years, 5 months ago (2012-07-11 23:16:55 UTC) #1
Albert Bodenhamer
https://chromiumcodereview.appspot.com/10696181/diff/5/chrome/service/service_process_prefs_unittest.cc File chrome/service/service_process_prefs_unittest.cc (right): https://chromiumcodereview.appspot.com/10696181/diff/5/chrome/service/service_process_prefs_unittest.cc#newcode7 chrome/service/service_process_prefs_unittest.cc:7: #include "base/file_util.h" Do you need file_util or path_service? Or ...
8 years, 5 months ago (2012-07-11 23:26:52 UTC) #2
Mehrdad
On 2012/07/11 23:26:52, Albert Bodenhamer wrote: > https://chromiumcodereview.appspot.com/10696181/diff/5/chrome/service/service_process_prefs_unittest.cc > File chrome/service/service_process_prefs_unittest.cc (right): > > https://chromiumcodereview.appspot.com/10696181/diff/5/chrome/service/service_process_prefs_unittest.cc#newcode7 ...
8 years, 5 months ago (2012-07-11 23:30:10 UTC) #3
Albert Bodenhamer
Counterpoint: Double check that you're not using anything that's implicitly pulled in. Include what you ...
8 years, 5 months ago (2012-07-11 23:34:01 UTC) #4
Mehrdad
On 2012/07/11 23:34:01, Albert Bodenhamer wrote: > Counterpoint: Double check that you're not using anything ...
8 years, 5 months ago (2012-07-11 23:36:15 UTC) #5
Mehrdad
Should be fixed.
8 years, 5 months ago (2012-07-11 23:57:56 UTC) #6
Albert Bodenhamer
lgtm
8 years, 5 months ago (2012-07-12 00:04:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mniknami@chromium.org/10696181/5004
8 years, 5 months ago (2012-07-12 17:24:39 UTC) #8
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 18:41:50 UTC) #9
Change committed as 146400

Powered by Google App Engine
This is Rietveld 408576698