Added unit test for ServiceProcessPrefs

Added unit test for ServiceProcessPrefs

Just added a unit test to ServiceProcessPrefs.
TEST=ServiceProcessPrefsTest.RetrievePrefs


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146400

[Albert Bodenhamer, 2012-07-11 23:26:52]

https://chromiumcodereview.appspot.com/10696181/diff/5/chrome/service/service...
File chrome/service/service_process_prefs_unittest.cc (right):

https://chromiumcodereview.appspot.com/10696181/diff/5/chrome/service/service...
chrome/service/service_process_prefs_unittest.cc:7: #include "base/file_util.h"
Do you need file_util or path_service? Or chrome_paths?

I'm not seeing where they're used (I might be missing something)

[Mehrdad, 2012-07-11 23:30:10]

On 2012/07/11 23:26:52, Albert Bodenhamer wrote:
>
https://chromiumcodereview.appspot.com/10696181/diff/5/chrome/service/service...
> File chrome/service/service_process_prefs_unittest.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10696181/diff/5/chrome/service/service...
> chrome/service/service_process_prefs_unittest.cc:7: #include
"base/file_util.h"
> Do you need file_util or path_service? Or chrome_paths?
> 
> I'm not seeing where they're used (I might be missing something)

Oops, no you're definitely not -- I'd deleted the part that needed them. I'll
fix it, thanks.

[Albert Bodenhamer, 2012-07-11 23:34:01]

Counterpoint: Double check that you're not using anything that's implicitly
pulled in.  Include what you use, and only what you use. :-)


On Wed, Jul 11, 2012 at 4:30 PM, <mniknami@chromium.org> wrote:

> On 2012/07/11 23:26:52, Albert Bodenhamer wrote:
>
> https://chromiumcodereview.**appspot.com/10696181/diff/5/**
>
chrome/service/service_**process_prefs_unittest.cc<https://chromiumcodereview.appspot.com/10696181/diff/5/chrome/service/service_process_prefs_unittest.cc>
>
>> File chrome/service/service_**process_prefs_unittest.cc (right):
>>
>
>
> https://chromiumcodereview.**appspot.com/10696181/diff/5/**
>
chrome/service/service_**process_prefs_unittest.cc#**newcode7<https://chromiumcodereview.appspot.com/10696181/diff/5/chrome/service/service_process_prefs_unittest.cc#newcode7>
>
>> chrome/service/service_**process_prefs_unittest.cc:7: #include
>>
> "base/file_util.h"
>
>> Do you need file_util or path_service? Or chrome_paths?
>>
>
>  I'm not seeing where they're used (I might be missing something)
>>
>
> Oops, no you're definitely not -- I'd deleted the part that needed them.
> I'll
> fix it, thanks.
>
>
https://chromiumcodereview.**appspot.com/10696181/<https://chromiumcodereview...
>



-- 
Albert Bodenhamer | Software Engineer | abodenha@chromium.<abodenha@google.com>
org

[Mehrdad, 2012-07-11 23:36:15]

On 2012/07/11 23:34:01, Albert Bodenhamer wrote:
> Counterpoint: Double check that you're not using anything that's implicitly
pulled in.  Include what you use, and only what you use. :-)

Haha yup, I'll check; thanks!

[Mehrdad, 2012-07-11 23:57:56]

Should be fixed.

[Albert Bodenhamer, 2012-07-12 00:04:03]

lgtm

[commit-bot: I haz the power, 2012-07-12 17:24:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mniknami@chromium.org/10696181/5004

[commit-bot: I haz the power, 2012-07-12 18:41:50]

Change committed as 146400