Issue 10696178: Fix bug in CompilationHandlescope constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10696178: Fix bug in CompilationHandlescope constructor. (Closed)

Created:
8 years, 5 months ago by sanjoy

Modified:
8 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev, Yang

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix bug in CompilationHandlescope constructor. This will never be triggered in the state v8 is currently in, but will crash v8 when multiple DeferredHandles are queued up during parallel compilation. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12050

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/api.h	View		1 chunk	+3 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 5 months ago (2012-07-12 07:22:23 UTC) #2

lgtm

http://codereview.chromium.org/10696178/diff/1/src/api.h
File src/api.h (right):

http://codereview.chromium.org/10696178/diff/1/src/api.h#newcode402
src/api.h:402: : next_(next), previous_(NULL),
first_block_limit_(first_block_limit),
nit: While you are at it, put each of these initializers onto its own line,
please.

Expand Messages | Collapse Messages