Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10696176: Move UserScript and related into extensions namespace (Closed)

Created:
8 years, 5 months ago by Devlin
Modified:
8 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, zork+watch_chromium.org, oshima+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, rdsmith+dwatch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, brettw-cc_chromium.org, ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move UserScript and related into extensions namespace Moved UserScript, UserScriptMaster, UserScriptSlave, UserScriptListener, and UserScriptScheduler into extensions namespace. BUG=136876, 117261 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146682

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Requested changes + latest master #

Patch Set 3 : Latest master for cq #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -85 lines) Patch
M chrome/browser/chromeos/accessibility/accessibility_util.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/download/download_crx_util.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/tabs/execute_code_in_tab_function.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/execute_code_in_tab_function.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/convert_user_script.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/convert_user_script.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/convert_user_script_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_system.h View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/user_script_listener.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/user_script_listener.cc View 5 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/extensions/user_script_listener_unittest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/user_script_master.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/user_script_master.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/extensions/user_script_master_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile.h View 1 2 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/common/extensions/user_script.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/user_script.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/user_script_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_context.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/extensions/extension_dispatcher.h View 1 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/extension_dispatcher.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/extensions/extension_helper.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/extensions/file_system_natives.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/extensions/user_script_scheduler.h View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/renderer/extensions/user_script_scheduler.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/renderer/extensions/user_script_slave.h View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/user_script_slave.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/test/base/testing_profile.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request.h View 1 4 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Devlin
Please review when time allows. mirandac: c/b/profiles rsleevi: net/ asargent: c/[b,c,r]/extensions (sorry it's so many) ...
8 years, 5 months ago (2012-07-12 23:02:03 UTC) #1
Ryan Sleevi
net/ rubberstamp LGTM with nits. https://chromiumcodereview.appspot.com/10696176/diff/2001/net/url_request/url_request.h File net/url_request/url_request.h (right): https://chromiumcodereview.appspot.com/10696176/diff/2001/net/url_request/url_request.h#newcode59 net/url_request/url_request.h:59: namespace extensions { nit: ...
8 years, 5 months ago (2012-07-12 23:38:05 UTC) #2
Miranda Callahan
profiles/* LGTM. On 2012/07/12 23:38:05, Ryan Sleevi wrote: > net/ rubberstamp LGTM with nits. > ...
8 years, 5 months ago (2012-07-13 12:03:03 UTC) #3
Devlin
https://chromiumcodereview.appspot.com/10696176/diff/2001/net/url_request/url_request.h File net/url_request/url_request.h (right): https://chromiumcodereview.appspot.com/10696176/diff/2001/net/url_request/url_request.h#newcode59 net/url_request/url_request.h:59: namespace extensions { On 2012/07/12 23:38:06, Ryan Sleevi wrote: ...
8 years, 5 months ago (2012-07-13 15:46:32 UTC) #4
asargent_no_longer_on_chrome
c/[b,c,r]/extensions LGTM
8 years, 5 months ago (2012-07-13 18:21:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10696176/11001
8 years, 5 months ago (2012-07-13 19:38:16 UTC) #6
commit-bot: I haz the power
Try job failure for 10696176-11001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-13 20:50:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10696176/10004
8 years, 5 months ago (2012-07-13 21:52:02 UTC) #8
commit-bot: I haz the power
8 years, 5 months ago (2012-07-13 23:12:42 UTC) #9 
Change committed as 146682

Powered by Google App Engine
This is Rietveld 408576698