Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: content/browser/android/content_view_core_impl.h

Issue 10696173: Revert "Revert 146000 - Split out ContentViewCore from ContentView for embedders." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase number deux Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/android/content_view_client.cc ('k') | content/browser/android/content_view_core_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/android/content_view_core_impl.h
diff --git a/content/browser/android/content_view_impl.h b/content/browser/android/content_view_core_impl.h
similarity index 86%
rename from content/browser/android/content_view_impl.h
rename to content/browser/android/content_view_core_impl.h
index 858c64efbadabfee0f89750653ec3db864cdd73d..46c00d4d41796c44c162f124aa4d105d6bc79732 100644
--- a/content/browser/android/content_view_impl.h
+++ b/content/browser/android/content_view_core_impl.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CONTENT_BROWSER_ANDROID_CONTENT_VIEW_IMPL_H_
-#define CONTENT_BROWSER_ANDROID_CONTENT_VIEW_IMPL_H_
+#ifndef CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
+#define CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
#include "base/android/jni_helper.h"
#include "base/basictypes.h"
@@ -11,7 +11,7 @@
#include "base/i18n/rtl.h"
#include "base/memory/scoped_ptr.h"
#include "base/process.h"
-#include "content/public/browser/android/content_view.h"
+#include "content/public/browser/android/content_view_core.h"
#include "content/public/browser/notification_observer.h"
#include "googleurl/src/gurl.h"
#include "ui/gfx/rect.h"
@@ -21,12 +21,12 @@ class ContentViewClient;
class RenderWidgetHostViewAndroid;
// TODO(jrg): this is a shell. Upstream the rest.
-class ContentViewImpl : public ContentView,
- public NotificationObserver {
+class ContentViewCoreImpl : public ContentViewCore,
+ public NotificationObserver {
public:
- ContentViewImpl(JNIEnv* env,
- jobject obj,
- WebContents* web_contents);
+ ContentViewCoreImpl(JNIEnv* env,
+ jobject obj,
+ WebContents* web_contents);
virtual void Destroy(JNIEnv* env, jobject obj);
// --------------------------------------------------------------------------
@@ -102,7 +102,7 @@ class ContentViewImpl : public ContentView,
// --------------------------------------------------------------------------
// Private methods that call to Java via JNI
// --------------------------------------------------------------------------
- virtual ~ContentViewImpl();
+ virtual ~ContentViewCoreImpl();
// --------------------------------------------------------------------------
// Other private methods and data
@@ -116,20 +116,20 @@ class ContentViewImpl : public ContentView,
JavaObject* java_object_;
// Reference to the current WebContents used to determine how and what to
- // display in the ContentView.
+ // display in the ContentViewCore.
WebContents* web_contents_;
// We only set this to be the delegate of the web_contents if we own it.
scoped_ptr<ContentViewClient> content_view_client_;
- // Whether the renderer backing this ContentView has crashed.
+ // Whether the renderer backing this ContentViewCore has crashed.
bool tab_crashed_;
- DISALLOW_COPY_AND_ASSIGN(ContentViewImpl);
+ DISALLOW_COPY_AND_ASSIGN(ContentViewCoreImpl);
};
-bool RegisterContentView(JNIEnv* env);
+bool RegisterContentViewCore(JNIEnv* env);
}; // namespace content
-#endif // CONTENT_BROWSER_ANDROID_CONTENT_VIEW_IMPL_H_
+#endif // CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
« no previous file with comments | « content/browser/android/content_view_client.cc ('k') | content/browser/android/content_view_core_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698