Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 10696170: Fix SDK installer by downloading r20 directly (Closed)

Created:
8 years, 5 months ago by Isaac (away)
Modified:
8 years, 5 months ago
Reviewers:
John Grabowski, bulach
CC:
chromium-reviews
Visibility:
Public.

Description

Fix SDK installer by downloading r20 directly - also renaming conflicting emulator avds This change should not be disruptive as android update step will rev tools to r20. However 'android-15' target does not exist for tools r18, so it was not being downloaded on a clean run of install-build-deps-android-sdk BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146112

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M build/android/emulator.py View 3 chunks +3 lines, -3 lines 0 comments Download
M build/install-build-deps-android-sdk.sh View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Isaac (away)
We've had a lot of these patches going around :-) Looks like we still haven't ...
8 years, 5 months ago (2012-07-11 09:36:45 UTC) #1
bulach
lgtm
8 years, 5 months ago (2012-07-11 11:36:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/10696170/1
8 years, 5 months ago (2012-07-11 11:43:55 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 13:44:28 UTC) #4
Change committed as 146112

Powered by Google App Engine
This is Rietveld 408576698