Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 10696169: Automating a Chrome crash when Accessibility is turned on. (Closed)

Created:
8 years, 5 months ago by rohitbm
Modified:
8 years, 5 months ago
Reviewers:
krisr
CC:
chromium-reviews, tturchetto
Visibility:
Public.

Description

We saw a Chrome crash on changing the device volume in Guest mode if Accessibility has been turned on. This automation test will catch this type of crash. TEST=None BUG=129218 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146263

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M functional/chromeos_accessibility.py View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rohitbm
8 years, 5 months ago (2012-07-11 02:23:43 UTC) #1
krisr
8 years, 5 months ago (2012-07-12 01:29:31 UTC) #2
LGTM


On Tue, Jul 10, 2012 at 7:23 PM, <rohitbm@chromium.org> wrote:

> Reviewers: krisr,
>
> Description:
> We saw a Chrome crash on changing the device volume in Guest mode if
> Accessibility has been turned on. This automation test will catch this
> type of
> crash.
>
> TEST=None
> BUG=129218
>
> Please review this at
https://chromiumcodereview.**appspot.com/10696169/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/chrome/test/<http://svn.chromium.org/chrome/trunk/src/chrome/test/>
>
> Affected files:
>   M     functional/chromeos_**accessibility.py
>
>
> Index: functional/chromeos_**accessibility.py
> ==============================**==============================**=======
> --- functional/chromeos_**accessibility.py        (revision 146025)
> +++ functional/chromeos_**accessibility.py        (working copy)
> @@ -7,6 +7,7 @@
>  import os
>  import subprocess
>  import sys
> +import time
>
>  import pyauto_functional
>  import pyauto
> @@ -74,6 +75,13 @@
>      self.NavigateToURL(url)
>      self.assertEqual(1, self.FindInPage('title')['**match_count'],
>          msg='Failed to load the page or find the page contents.')
> +    # crbug.com/129218: adding a volume change functionality to automate
> this
> +    # issue. Please note that we don't verify any functionality here.
> +    default_volume = self.GetVolumeInfo()
> +    for test_volume in (50.00, 77.00, 85.00, 20.00):
> +      self.SetVolume(test_volume)
> +      time.sleep(1)
> +    self.SetVolume(default_volume.**get('volume'))
>
>    def testAccessibilityBeforeLogin(**self):
>      """Test Accessibility before login."""
>
>
>

Powered by Google App Engine
This is Rietveld 408576698