Do not ignore F3-F7 and F9 key presses on an Apple keyboard.

Do not ignore F3-F7 and F9 key presses on an Apple keyboard.

BUG=123739
TEST=try


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146131

[Yusuke Sato, 2012-07-10 20:22:27]

Daniel, could you review this? This is the first step for supporting Apple media
keys.

[Daniel Erat, 2012-07-10 20:24:25]

LGTM with one change.

http://codereview.chromium.org/10696161/diff/1/ui/base/keycodes/keyboard_code...
File ui/base/keycodes/keyboard_codes_posix.h (right):

http://codereview.chromium.org/10696161/diff/1/ui/base/keycodes/keyboard_code...
ui/base/keycodes/keyboard_codes_posix.h:214: VKEY_KEY_BRIGHTNESS_DOWN = 0xDA,
nit: s/VKEY_KEY_/VKEY_KEYBOARD_/ or VKEY_KBD_

otherwise it's a bit confusing

[Yusuke Sato, 2012-07-10 20:43:52]

Thanks, fixed.

http://codereview.chromium.org/10696161/diff/1/ui/base/keycodes/keyboard_code...
File ui/base/keycodes/keyboard_codes_posix.h (right):

http://codereview.chromium.org/10696161/diff/1/ui/base/keycodes/keyboard_code...
ui/base/keycodes/keyboard_codes_posix.h:214: VKEY_KEY_BRIGHTNESS_DOWN = 0xDA,
On 2012/07/10 20:24:25, Daniel Erat wrote:
> nit: s/VKEY_KEY_/VKEY_KEYBOARD_/ or VKEY_KBD_
> 
> otherwise it's a bit confusing

Done.

http://codereview.chromium.org/10696161/diff/6001/ui/base/keycodes/keyboard_c...
File ui/base/keycodes/keyboard_code_conversion_x.cc (right):

http://codereview.chromium.org/10696161/diff/6001/ui/base/keycodes/keyboard_c...
ui/base/keycodes/keyboard_code_conversion_x.cc:723: case VKEY_MEDIA_NEXT_TRACK:
also added code for reverse conversion for consistency.

[Yusuke Sato, 2012-07-10 21:12:03]

Ben, could you do an owners review?

[Ben Goodger (Google), 2012-07-11 15:43:03]

lgtm

[commit-bot: I haz the power, 2012-07-11 16:17:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/10696161/6001

[commit-bot: I haz the power, 2012-07-11 17:10:45]

Change committed as 146131