Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 10696158: Rename WasRestored to WasShown across all uses. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Bring to ToT to commit Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index 8ed673b2a33ecfb2a9199410954a712db5f39b38..9ad8be631cb88dd0a933ef3547cda0afe7453af6 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -364,7 +364,7 @@ void RenderWidgetHostImpl::WasHidden() {
Details<bool>(&is_visible));
}
-void RenderWidgetHostImpl::WasRestored() {
+void RenderWidgetHostImpl::WasShown() {
// When we create the widget, it is created as *not* hidden.
if (!is_hidden_)
return;
@@ -383,7 +383,7 @@ void RenderWidgetHostImpl::WasRestored() {
} else {
needs_repainting = false;
}
- Send(new ViewMsg_WasRestored(routing_id_, needs_repainting));
+ Send(new ViewMsg_WasShown(routing_id_, needs_repainting));
process_->WidgetRestored();
@@ -404,9 +404,9 @@ void RenderWidgetHostImpl::WasRestored() {
// By invoking WasResized the renderer is updated as necessary. WasResized
// does nothing if the sizes are already in sync.
//
- // TODO: ideally ViewMsg_WasRestored would take a size. This way, the renderer
+ // TODO: ideally ViewMsg_WasShown would take a size. This way, the renderer
// could handle both the restore and resize at once. This isn't that big a
- // deal as RenderWidget::WasRestored delays updating, so that the resize from
+ // deal as RenderWidget::WasShown delays updating, so that the resize from
// WasResized is usually processed before the renderer is painted.
WasResized();
}
@@ -606,7 +606,7 @@ BackingStore* RenderWidgetHostImpl::GetBackingStore(bool force_create) {
"height", base::IntToString(view_size.height()));
// We should not be asked to paint while we are hidden. If we are hidden,
- // then it means that our consumer failed to call WasRestored. If we're not
+ // then it means that our consumer failed to call WasShown. If we're not
// force creating the backing store, it's OK since we can feel free to give
// out our cached one if we have it.
DCHECK(!is_hidden_ || !force_create) <<
« no previous file with comments | « content/browser/renderer_host/render_widget_host_impl.h ('k') | content/browser/renderer_host/render_widget_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698