Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 10696151: Skeleton of a linear scan register allocator. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_builder.cc
diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc
index eb1ccda6c1e9a3209868f21879776b0112d518ad..1ebefc6026518e98489a3929c70355dcc804a53d 100644
--- a/runtime/vm/flow_graph_builder.cc
+++ b/runtime/vm/flow_graph_builder.cc
@@ -1072,8 +1072,10 @@ void EffectGraphVisitor::VisitWhileNode(WhileNode* node) {
ASSERT(!for_test.is_empty()); // Language spec.
EffectGraphVisitor for_body(owner(), temp_index());
+#if 0
srdjan 2012/07/11 17:22:32 Enable stack overflow check before submitting
for_body.Do(
new CheckStackOverflowComp(node->token_pos(), owner()->try_index()));
+#endif
node->body()->Visit(&for_body);
// Labels are set after body traversal.
@@ -1100,8 +1102,10 @@ void EffectGraphVisitor::VisitWhileNode(WhileNode* node) {
void EffectGraphVisitor::VisitDoWhileNode(DoWhileNode* node) {
// Traverse body first in order to generate continue and break labels.
EffectGraphVisitor for_body(owner(), temp_index());
+#if 0
for_body.Do(
new CheckStackOverflowComp(node->token_pos(), owner()->try_index()));
+#endif
node->body()->Visit(&for_body);
TestGraphVisitor for_test(owner(),
@@ -1164,8 +1168,10 @@ void EffectGraphVisitor::VisitForNode(ForNode* node) {
EffectGraphVisitor for_body(owner(), temp_index());
TargetEntryInstr* body_entry = new TargetEntryInstr();
for_body.AddInstruction(body_entry);
+#if 0
for_body.Do(
new CheckStackOverflowComp(node->token_pos(), owner()->try_index()));
+#endif
node->body()->Visit(&for_body);
// Join loop body, increment and compute their end instruction.

Powered by Google App Engine
This is Rietveld 408576698