Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 10696148: Move TabStripModelDelegate off Browser into its own class. (Closed)

Created:
8 years, 5 months ago by Ben Goodger (Google)
Modified:
8 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, sadrul, Aaron Boodman, ben+watch_chromium.org, kkania, dcheng, marja+watch_chromium.org, robertshield
Visibility:
Public.

Description

Move TabStripModelDelegate off Browser into its own class. http://crbug.com/133576 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145932

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+376 lines, -243 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui_default.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_restore_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.h View 5 chunks +3 lines, -32 lines 0 comments Download
M chrome/browser/ui/browser.cc View 3 chunks +6 lines, -173 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_commands.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 11 chunks +73 lines, -17 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A chrome/browser/ui/browser_tab_strip_model_delegate.h View 1 2 1 chunk +73 lines, -0 lines 0 comments Download
A chrome/browser/ui/browser_tab_strip_model_delegate.cc View 1 2 1 chunk +167 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_tabstrip.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_tabstrip.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_delegate.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/ash/chrome_shell_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/app_non_client_frame_view_aura_browsertest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jam
8 years, 5 months ago (2012-07-10 15:35:06 UTC) #1
lgtm

Powered by Google App Engine
This is Rietveld 408576698