lib/compiler/implementation/elements/elements.dart - Issue 10696147: Patch methods in classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/elements/elements.dart

Issue 10696147: Patch methods in classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Small type/typo fixes Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/compiler/implementation/elements/elements.dart

diff --git a/lib/compiler/implementation/elements/elements.dart b/lib/compiler/implementation/elements/elements.dart

index f47f30a2ee7e1053411d32fd231d9edf30d7565c..5122c65e2cd2fdaf1dc98f92ca50ee7b9fadacde 100644

--- a/lib/compiler/implementation/elements/elements.dart

+++ b/lib/compiler/implementation/elements/elements.dart

@@ -716,10 +716,10 @@ class FunctionElement extends Element {

if (cachedNode !== null) return cachedNode;

if (patch === null) {

if (modifiers.isExternal()) {

- // An external function that isn't patched has no body.

- return null;

+ listener.cancel("Compiling external function with no implementation.",

+ element: this);

}

- return cachedNode;

+ return null;

}

cachedNode = patch.parseNode(listener);

return cachedNode;