Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1498)

Unified Diff: chrome/browser/extensions/api/metrics/metrics.cc

Issue 10696145: Moving metrics to api/ . (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Putting back "using" and updating WATCHLISTS Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/metrics/metrics.cc
diff --git a/chrome/browser/extensions/extension_metrics_module.cc b/chrome/browser/extensions/api/metrics/metrics.cc
similarity index 84%
rename from chrome/browser/extensions/extension_metrics_module.cc
rename to chrome/browser/extensions/api/metrics/metrics.cc
index 0c63a7aee1ab21c182ef9a2a8e31b8e5692539df..eb7c92446c1f8f5e8d5199d9af43cfcb31a92e75 100644
--- a/chrome/browser/extensions/extension_metrics_module.cc
+++ b/chrome/browser/extensions/api/metrics/metrics.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/extensions/extension_metrics_module.h"
+#include "chrome/browser/extensions/api/metrics/metrics.h"
#include <algorithm>
@@ -10,13 +10,17 @@
#include "chrome/common/extensions/extension.h"
#include "content/public/browser/user_metrics.h"
+namespace extensions {
+
using base::Histogram;
using base::LinearHistogram;
-using content::UserMetricsAction;
+
+namespace {
const size_t kMaxBuckets = 10000; // We don't ever want more than these many
// buckets; there is no real need for them
// and would cause crazy memory usage
+} // namespace
bool MetricsRecordUserActionFunction::RunImpl() {
std::string name;
@@ -33,12 +37,11 @@ bool MetricsHistogramHelperFunction::GetNameAndSample(std::string* name,
return true;
}
-bool MetricsHistogramHelperFunction::RecordValue(const std::string& name,
- Histogram::ClassType type,
- int min,
- int max,
- size_t buckets,
- int sample) {
+bool MetricsHistogramHelperFunction::RecordValue(
+ const std::string& name,
+ Histogram::ClassType type,
+ int min, int max, size_t buckets,
+ int sample) {
// Make sure toxic values don't get to internal code.
// Fix for maximums
min = std::min(min, INT_MAX - 3);
@@ -55,15 +58,11 @@ bool MetricsHistogramHelperFunction::RecordValue(const std::string& name,
Histogram* counter;
if (type == Histogram::LINEAR_HISTOGRAM) {
counter = LinearHistogram::FactoryGet(name,
- min,
- max,
- buckets,
+ min, max, buckets,
Histogram::kUmaTargetedHistogramFlag);
} else {
counter = Histogram::FactoryGet(name,
- min,
- max,
- buckets,
+ min, max, buckets,
Histogram::kUmaTargetedHistogramFlag);
}
@@ -99,7 +98,10 @@ bool MetricsRecordPercentageFunction::RunImpl() {
std::string name;
int sample;
EXTENSION_FUNCTION_VALIDATE(GetNameAndSample(&name, &sample));
- return RecordValue(name, Histogram::LINEAR_HISTOGRAM, 1, 101, 102, sample);
+ return RecordValue(name,
+ Histogram::LINEAR_HISTOGRAM,
+ 1, 101, 102,
+ sample);
}
bool MetricsRecordCountFunction::RunImpl() {
@@ -146,3 +148,5 @@ bool MetricsRecordLongTimeFunction::RunImpl() {
static const int kOneHourMs = 60 * 60 * 1000;
return RecordValue(name, Histogram::HISTOGRAM, 1, kOneHourMs, 50, sample);
}
+
+} // namespace extensions
« no previous file with comments | « chrome/browser/extensions/api/metrics/metrics.h ('k') | chrome/browser/extensions/api/metrics/metrics_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698