Issue 10696139: Improved printing of CheckPrototypeMaps instruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10696139: Improved printing of CheckPrototypeMaps instruction. (Closed)

Created:
8 years, 5 months ago by Sven Panne

Modified:
8 years, 5 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Improved printing of CheckPrototypeMaps instruction.

Patch Set 1 #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	src/hydrogen-instructions.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/hydrogen-instructions.cc	View		1 chunk	+5 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM with comment. http://codereview.chromium.org/10696139/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): http://codereview.chromium.org/10696139/diff/1/src/hydrogen-instructions.cc#newcode1077 src/hydrogen-instructions.cc:1077: stream->Add("[receiver_prototype=%p,holder=%p]", *prototype(), *holder()); maybe add a ...

8 years, 5 months ago (2012-07-09 10:39:02 UTC) #2

Sven Panne

8 years, 5 months ago (2012-07-09 10:44:08 UTC) #3

Landing...

http://codereview.chromium.org/10696139/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):

http://codereview.chromium.org/10696139/diff/1/src/hydrogen-instructions.cc#n...
src/hydrogen-instructions.cc:1077:
stream->Add("[receiver_prototype=%p,holder=%p]", *prototype(), *holder());
On 2012/07/09 10:39:02, Yang wrote:
> maybe add a whitespace after comma.

Similar PrintDataTo functions don't add one, either, so I think I'll leave it as
it is for consistency reasons.

Expand Messages | Collapse Messages