Offload disk accesses to WorkerPool in ExtensionProtocolHandler

net/url_request/url_request_simple_job.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_SIMPLE_JOB_H_
 #define NET_URL_REQUEST_URL_REQUEST_SIMPLE_JOB_H_
 #pragma once
 
 #include <string>
 
 #include "base/memory/weak_ptr.h"
+#include "net/base/completion_callback.h"
 #include "net/base/net_export.h"
 #include "net/url_request/url_request_job.h"
 
 namespace net {
 
 class URLRequest;
 
 class NET_EXPORT URLRequestSimpleJob : public URLRequestJob {
  public:
   explicit URLRequestSimpleJob(URLRequest* request);
 
   virtual void Start() OVERRIDE;
   virtual bool ReadRawData(IOBuffer* buf,
                            int buf_size,
                            int *bytes_read) OVERRIDE;
   virtual bool GetMimeType(std::string* mime_type) const OVERRIDE;
   virtual bool GetCharset(std::string* charset) OVERRIDE;
 
  protected:
   virtual ~URLRequestSimpleJob();
 
-  // subclasses must override the way response data is determined.
-  virtual bool GetData(std::string* mime_type,
-                       std::string* charset,
-                       std::string* data) const = 0;
+  // Subclasses must override the way response data is determined.
+  // The return value should be net::OK if data is obtained;
+  // net::ERR_IO_PENDING if processing in another thread is needed to finish
+  // obtaining data; and net::ERR_FAILED to indicate an error. If method
+  // returns net::ERR_IO_PENDING then |callback| should be called when
+  // operation is completed. In other situations |callback| should never be
+  // called.

[wtc, 2012/07/11 01:08:46]

Nit: remove net:: in this comment block because this class
is inside the net namespace.

should be called => will be called
should never be called => will not be called

[wtc, 2012/07/11 18:48:50]

I see.  Then the use of "should" is appropriate in this comment.
Sorry about my confusion.

Nit: the second sentence might be clearer in a bullet point
form:

  The return value should be
  * OK if data is obtained;
  * ERR_IO_PENDING if processing in another thread is needed to finish obtaining
data; and
  * ERR_FAILED to indicate an error.

+  virtual int GetData(std::string* mime_type,
+                      std::string* charset,
+                      std::string* data,
+                      const CompletionCallback& callback) const = 0;
 
  protected:
   void StartAsync();
 
  private:
+  void OnGetDataCompleted(int result);
+
   std::string mime_type_;
   std::string charset_;
   std::string data_;
   int data_offset_;
   base::WeakPtrFactory<URLRequestSimpleJob> weak_factory_;
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_SIMPLE_JOB_H_