Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10696130: Get rid of implicit conversion to and from ImageSkiaRep (Closed)

Created:
8 years, 5 months ago by pkotwicz
Modified:
8 years, 5 months ago
CC:
chromium-reviews, dcheng, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Get rid of implicit conversion to and from ImageSkiaRep Bug=None Test=Compiles R=ben,oshima TBR=sadrul Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146022

Patch Set 1 #

Patch Set 2 : 0 #

Total comments: 5

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -55 lines) Patch
M chrome/browser/chromeos/status/network_menu_icon.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/avatar_menu_item_gtk.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/browser_action_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_dropdown.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/image/image_skia.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/gfx/image/image_skia.cc View 3 chunks +2 lines, -14 lines 0 comments Download
M ui/gfx/image/image_skia_rep.h View 1 chunk +0 lines, -10 lines 0 comments Download
M ui/gfx/image/image_skia_rep.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M ui/views/controls/menu/menu_win.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M ui/views/controls/menu/native_menu_win.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
pkotwicz
8 years, 5 months ago (2012-07-07 04:19:50 UTC) #1
oshima
https://chromiumcodereview.appspot.com/10696130/diff/9001/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc File chrome/browser/ui/webui/chromeos/login/network_dropdown.cc (right): https://chromiumcodereview.appspot.com/10696130/diff/9001/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc#newcode89 chrome/browser/ui/webui/chromeos/login/network_dropdown.cc:89: SkBitmap icon_bitmap = icon.GetRepresentation( shouldn't this be ImageSkiaRep? https://chromiumcodereview.appspot.com/10696130/diff/9001/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc#newcode164 ...
8 years, 5 months ago (2012-07-09 18:22:22 UTC) #2
pkotwicz
https://chromiumcodereview.appspot.com/10696130/diff/9001/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc File chrome/browser/ui/webui/chromeos/login/network_dropdown.cc (right): https://chromiumcodereview.appspot.com/10696130/diff/9001/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc#newcode89 chrome/browser/ui/webui/chromeos/login/network_dropdown.cc:89: SkBitmap icon_bitmap = icon.GetRepresentation( Nope, we get the bitmap. ...
8 years, 5 months ago (2012-07-09 19:36:35 UTC) #3
oshima
lgtm https://chromiumcodereview.appspot.com/10696130/diff/9001/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc File chrome/browser/ui/webui/chromeos/login/network_dropdown.cc (right): https://chromiumcodereview.appspot.com/10696130/diff/9001/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc#newcode89 chrome/browser/ui/webui/chromeos/login/network_dropdown.cc:89: SkBitmap icon_bitmap = icon.GetRepresentation( On 2012/07/09 19:36:36, pkotwicz ...
8 years, 5 months ago (2012-07-09 19:40:58 UTC) #4
pkotwicz
Ben for OWNERS
8 years, 5 months ago (2012-07-09 19:42:53 UTC) #5
pkotwicz
Ben for OWNERS
8 years, 5 months ago (2012-07-09 19:43:18 UTC) #6
Ben Goodger (Google)
lgtm
8 years, 5 months ago (2012-07-10 15:02:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10696130/15002
8 years, 5 months ago (2012-07-10 18:06:45 UTC) #8
commit-bot: I haz the power
Presubmit check for 10696130-15002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-10 18:06:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10696130/15002
8 years, 5 months ago (2012-07-10 18:08:34 UTC) #10
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 5 months ago (2012-07-10 19:41:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10696130/15002
8 years, 5 months ago (2012-07-10 20:55:44 UTC) #12
commit-bot: I haz the power
Try job failure for 10696130-15002 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-10 22:26:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10696130/28002
8 years, 5 months ago (2012-07-11 00:26:20 UTC) #14
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 01:30:25 UTC) #15 
Change committed as 146022

Powered by Google App Engine
This is Rietveld 408576698