Issue 10696128: remoting: Fix typo in TODO.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10696128: remoting: Fix typo in TODO. (Closed)

Created:
8 years, 5 months ago by tfarina

Modified:
8 years, 5 months ago

Reviewers:
alexeypa (please no reviews), Lambros

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

remoting: Fix typo in TODO. R=lambroslambrou@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146345

Patch Set 1 #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	remoting/host/continue_window_gtk.cc	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tfarina

PTAL! http://codereview.chromium.org/10696128/diff/1/remoting/host/continue_window_gtk.cc File remoting/host/continue_window_gtk.cc (right): http://codereview.chromium.org/10696128/diff/1/remoting/host/continue_window_gtk.cc#newcode77 remoting/host/continue_window_gtk.cc:77: // TODO(lambroslambrou): Fix magic numbers, as in disconnect_window_gtk.cc. ...

8 years, 5 months ago (2012-07-06 22:18:46 UTC) #1

alexeypa (please no reviews)

8 years, 5 months ago (2012-07-10 18:11:11 UTC) #3

lgtm

http://codereview.chromium.org/10696128/diff/1/remoting/host/continue_window_...
File remoting/host/continue_window_gtk.cc (right):

http://codereview.chromium.org/10696128/diff/1/remoting/host/continue_window_...
remoting/host/continue_window_gtk.cc:77: // TODO(lambroslambrou): Fix magic
numbers, as in disconnect_window_gtk.cc.
On 2012/07/06 22:18:46, tfarina wrote:
> what is this todo about?

Probably, the idea is to rationalize the somewhat arbitrary constants scattered
around gtk_xxx calls and make them easier to understand and modify in the
future.

Expand Messages | Collapse Messages