Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 10696125: Fix bug in compilation-handlescope. (Closed)

Created:
8 years, 5 months ago by sanjoy
Modified:
8 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix bug in compilation-handlescope. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12003

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -11 lines) Patch
M src/api.h View 1 4 chunks +6 lines, -3 lines 0 comments Download
M src/api.cc View 1 3 chunks +19 lines, -6 lines 0 comments Download
M src/handles.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sanjoy
8 years, 5 months ago (2012-07-06 13:12:29 UTC) #1
Jakob Kummerow
http://codereview.chromium.org/10696125/diff/1/src/api.cc File src/api.cc (right): http://codereview.chromium.org/10696125/diff/1/src/api.cc#newcode6474 src/api.cc:6474: deferred_iterator = deferred_iterator->previous_; nit: {} please http://codereview.chromium.org/10696125/diff/1/src/api.cc#newcode6511 src/api.cc:6511: ASSERT((last_block_limit_ ...
8 years, 5 months ago (2012-07-06 13:30:32 UTC) #2
sanjoy
http://codereview.chromium.org/10696125/diff/1/src/api.cc File src/api.cc (right): http://codereview.chromium.org/10696125/diff/1/src/api.cc#newcode6474 src/api.cc:6474: deferred_iterator = deferred_iterator->previous_; On 2012/07/06 13:30:32, Jakob wrote: > ...
8 years, 5 months ago (2012-07-06 13:56:57 UTC) #3
Jakob Kummerow
8 years, 5 months ago (2012-07-06 14:04:10 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698