Fix very subtle bug in HNode.changeUse.

lib/compiler/implementation/ssa/nodes.dart

Index: lib/compiler/implementation/ssa/nodes.dart
diff --git a/lib/compiler/implementation/ssa/nodes.dart b/lib/compiler/implementation/ssa/nodes.dart
index 0e075d89c0d78aa0e2e4026d2deb1ba016b51a3f..99080847debc3357de8f6685a42a4a3a91e47ac9 100644
--- a/lib/compiler/implementation/ssa/nodes.dart
+++ b/lib/compiler/implementation/ssa/nodes.dart
@@ -931,10 +931,13 @@ class HInstruction implements Hashable {
       }
     }
     List<HInstruction> oldInputUsers = oldInput.usedBy;
-    for (int i = 0; i < oldInputUsers.length; i++) {
+    int i = 0;
+    while (i < oldInputUsers.length) {
       if (oldInputUsers[i] == this) {
         oldInputUsers[i] = oldInputUsers[oldInput.usedBy.length - 1];
         oldInputUsers.length = oldInputUsers.length - 1;

[Lasse Reichstein Nielsen, 2012/07/06 11:22:16]

Use 'oldInputUsers.length -= 1' here, or even 'oldInputUsers.length--'.

If order is irrelevant, and duplicates probably irrelevant, why do we use a List
and not a Set?

[floitsch, 2012/07/06 15:20:33]

done.
I'm not sure duplicates are irrelevant. Maybe another CL.

+      } else {
+        i++;
       }
     }
   }
@@ -949,11 +952,11 @@ class HInstruction implements Hashable {
 
     // Run through all the users and see if they are dominated or
     // potentially dominated by [other].
-    HBasicBlock block = other.block;
+    HBasicBlock otherBlock = other.block;
     for (int i = 0, length = usedBy.length; i < length; i++) {
       HInstruction current = usedBy[i];
-      if (current !== other && block.dominates(current.block)) {
-        if (current.block === block) usersInCurrentBlock++;
+      if (current !== other && otherBlock.dominates(current.block)) {
+        if (current.block === otherBlock) usersInCurrentBlock++;
         users.add(current);
       }
     }
@@ -961,7 +964,7 @@ class HInstruction implements Hashable {
     // Run through all the instructions before [other] and remove them
     // from the users set.
     if (usersInCurrentBlock > 0) {
-      HInstruction current = block.first;
+      HInstruction current = otherBlock.first;
       while (current !== other) {
         if (users.contains(current)) {
           users.remove(current);