Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 10696117: Fix build for native client to roll DEPS. (Closed)

Created:
8 years, 5 months ago by bbudge
Modified:
8 years, 5 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews
Visibility:
Public.

Description

Fix build for native client to roll DEPS. BUG=none TEST=compiles in NaCl repo Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145462

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/build_config.h View 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bbudge
This won't build in the Native Client repo, since it's undefined and we compile with ...
8 years, 5 months ago (2012-07-04 14:42:59 UTC) #1
stuartmorgan
LGTM (Sorry; forgot that's a warning in some compilations) FWIW, I specifically felt that the ...
8 years, 5 months ago (2012-07-04 14:47:51 UTC) #2
bbudge
8 years, 5 months ago (2012-07-04 15:21:35 UTC) #3
On 2012/07/04 14:47:51, stuartmorgan wrote:
> LGTM (Sorry; forgot that's a warning in some compilations)
> 
> FWIW, I specifically felt that the nested-#endif-in-chain-of-#if/#elif
warranted
> a comment despite being short (I normally omit them in that case as well), so
> think this is a loss for readability, but if it offends people I'm okay with
> removing it.

Thanks for the quick review. I'll add the comment back.

Powered by Google App Engine
This is Rietveld 408576698