|
|
Chromium Code Reviews|
Created:
8 years, 5 months ago by Junmin Zhu Modified:
8 years, 5 months ago CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org Base URL:
http://git.chromium.org/chromium/src.git@master Visibility:
Public. |
DescriptionRemove useless code in power_save_blocker_win.cc after changing to Win8 SDK.
BUG=
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146805
Patch Set 1 #
Messages
Total messages: 14 (0 generated)
After changing to Win8 SDK, this part of code never be touched, so propose to remove it. Please review the patch, thanks.
I'll defer to Ricardo.
Shouldn't we wait at least until the Win8 SDK goes out of beta? It doesn't look like a good idea to require people to install the current version of the SDK in order to compile Content, specially while it's still changing (and yes, I saw the latest version of published requirements on chromium.org). I guess that's more a question for cpu, not for this patch. In other words, LGTM, but I'd prefer waiting until the SDK is released before removing code that allows using an older^h current SDK.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junmin.zhu@intel.com/10696116/1
Presubmit check for 10696116-1 failed and returned exit status 1.
Running presubmit commit checks ...
** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].
If this change requires manual test instructions to QA team, add
TEST=[instructions].
** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
content/browser
In the build/common.gypi, |_WIN32_WINNT| was set as |0x0602| for windows platform, so if developer will build failed with |SDK| < |Win8 SDK|. In my mind, Win8 SDK is good enough, but it's decided by cpu.:) Add Jam for OWNER review. Thanks. Please kindly review the patch.
i defer to rvargas, if he says lgtm then ok
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junmin.zhu@intel.com/10696116/1
Change committed as 146805
On 2012/07/16 15:23:07, I haz the power (commit-bot) wrote: > Change committed as 146805 So every developer is forced to install beta Win8 SDK now? Can we at least wait as rvargas suggested?
Hi Arthur, There is no rush at all with this particular patch... if something is breaking for you, feel free to revert it and we'll land it later. We may be landing soon code that really needs the new sdk, but I don't think we have a specific date yet.
The warning was here: https://groups.google.com/a/chromium.org/d/topic/chromium-dev/ZteDXYbKItE/dis... On Thu, Jul 19, 2012 at 5:01 PM, <rvargas@chromium.org> wrote: > Hi Arthur, > > There is no rush at all with this particular patch... if something is > breaking > for you, feel free to revert it and we'll land it later. > > We may be landing soon code that really needs the new sdk, but I don't > think we > have a specific date yet. > > https://chromiumcodereview.**appspot.com/10696116/<https://chromiumcodereview... >
On 2012/07/20 00:01:18, rvargas wrote: > Hi Arthur, > > There is no rush at all with this particular patch... if something is breaking > for you, feel free to revert it and we'll land it later. > > We may be landing soon code that really needs the new sdk, but I don't think we > have a specific date yet. BTW, note that cpu changed the value of _WIN32_WINNT when enabling the new SDK, so a little tweaking is needed if using the old SDK.
The practical thing for goma would be to somehow use the platform sdk in src\third_party\ On Thu, Jul 19, 2012 at 5:05 PM, <rvargas@chromium.org> wrote: > On 2012/07/20 00:01:18, rvargas wrote: > >> Hi Arthur, >> > > There is no rush at all with this particular patch... if something is >> breaking >> for you, feel free to revert it and we'll land it later. >> > > We may be landing soon code that really needs the new sdk, but I don't >> think >> > we > >> have a specific date yet. >> > > BTW, note that cpu changed the value of _WIN32_WINNT when enabling the new > SDK, > so a little tweaking is needed if using the old SDK. > > https://chromiumcodereview.**appspot.com/10696116/<https://chromiumcodereview... > |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
