Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 10696116: Remove useless code in power_save_blocker_win.cc after changing to Win8 SDK. (Closed)

Created:
8 years, 5 months ago by Junmin Zhu
Modified:
8 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove useless code in power_save_blocker_win.cc after changing to Win8 SDK. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M content/browser/power_save_blocker_win.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Junmin Zhu
After changing to Win8 SDK, this part of code never be touched, so propose to ...
8 years, 5 months ago (2012-07-04 14:16:12 UTC) #1
cpu_(ooo_6.6-7.5)
I'll defer to Ricardo.
8 years, 5 months ago (2012-07-06 23:22:14 UTC) #2
rvargas (doing something else)
Shouldn't we wait at least until the Win8 SDK goes out of beta? It doesn't ...
8 years, 5 months ago (2012-07-13 00:00:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junmin.zhu@intel.com/10696116/1
8 years, 5 months ago (2012-07-15 11:57:20 UTC) #4
commit-bot: I haz the power
Presubmit check for 10696116-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-15 11:57:25 UTC) #5
Junmin Zhu
In the build/common.gypi, |_WIN32_WINNT| was set as |0x0602| for windows platform, so if developer will ...
8 years, 5 months ago (2012-07-15 14:17:59 UTC) #6
jam
i defer to rvargas, if he says lgtm then ok
8 years, 5 months ago (2012-07-16 05:26:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junmin.zhu@intel.com/10696116/1
8 years, 5 months ago (2012-07-16 14:06:23 UTC) #8
commit-bot: I haz the power
Change committed as 146805
8 years, 5 months ago (2012-07-16 15:23:07 UTC) #9
arthurhsu
On 2012/07/16 15:23:07, I haz the power (commit-bot) wrote: > Change committed as 146805 So ...
8 years, 5 months ago (2012-07-19 23:32:12 UTC) #10
rvargas (doing something else)
Hi Arthur, There is no rush at all with this particular patch... if something is ...
8 years, 5 months ago (2012-07-20 00:01:18 UTC) #11
cpu1
The warning was here: https://groups.google.com/a/chromium.org/d/topic/chromium-dev/ZteDXYbKItE/discussion On Thu, Jul 19, 2012 at 5:01 PM, <rvargas@chromium.org> wrote: ...
8 years, 5 months ago (2012-07-20 00:05:05 UTC) #12
rvargas (doing something else)
On 2012/07/20 00:01:18, rvargas wrote: > Hi Arthur, > > There is no rush at ...
8 years, 5 months ago (2012-07-20 00:05:08 UTC) #13
cpu1
8 years, 5 months ago (2012-07-20 00:21:10 UTC) #14
The practical thing for goma would be to somehow use the platform sdk in
src\third_party\




On Thu, Jul 19, 2012 at 5:05 PM, <rvargas@chromium.org> wrote:

> On 2012/07/20 00:01:18, rvargas wrote:
>
>> Hi Arthur,
>>
>
>  There is no rush at all with this particular patch... if something is
>> breaking
>> for you, feel free to revert it and we'll land it later.
>>
>
>  We may be landing soon code that really needs the new sdk, but I don't
>> think
>>
> we
>
>> have a specific date yet.
>>
>
> BTW, note that cpu changed the value of _WIN32_WINNT when enabling the new
> SDK,
> so  a little tweaking is needed if using the old SDK.
>
>
https://chromiumcodereview.**appspot.com/10696116/<https://chromiumcodereview...
>

Powered by Google App Engine
This is Rietveld 408576698