sync: Track validity of about:sync fields

chrome/browser/sync/sync_ui_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <set>
 #include "base/basictypes.h"
-#include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/signin/signin_manager.h"
 #include "chrome/browser/signin/signin_manager_fake.h"
 #include "chrome/browser/sync/profile_sync_service_mock.h"
 #include "chrome/browser/sync/sync_ui_util.h"
 #include "content/public/test/test_browser_thread.h"
 #include "grit/generated_resources.h"
 #include "testing/gmock/include/gmock/gmock-actions.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/l10n/l10n_util.h"
 
 using ::testing::AtMost;
+using ::testing::NiceMock;
 using ::testing::Return;
 using ::testing::ReturnRef;
-using ::testing::NiceMock;
+using ::testing::SetArgPointee;
+using ::testing::_;
 using content::BrowserThread;
 
 // A number of distinct states of the ProfileSyncService can be generated for
 // tests.
 enum DistinctState {
   STATUS_CASE_SETUP_IN_PROGRESS,
   STATUS_CASE_SETUP_ERROR,
   STATUS_CASE_AUTHENTICATING,
   STATUS_CASE_AUTH_ERROR,
   STATUS_CASE_PROTOCOL_ERROR,
@@ skipping 26 matching lines @@
   string16 label1, label2, label3;
   sync_ui_util::GetStatusLabelsForSyncGlobalError(
       service, signin, &label1, &label2, &label3);
   EXPECT_EQ(label1.empty(), !is_error);
   EXPECT_EQ(label2.empty(), !is_error);
   EXPECT_EQ(label3.empty(), !is_error);
 }
 
 } // namespace
 
-TEST(SyncUIUtilTest, ConstructAboutInformationWithUnrecoverableErrorTest) {
-  MessageLoopForUI message_loop;
-  content::TestBrowserThread ui_thread(BrowserThread::UI, &message_loop);
-  scoped_ptr<Profile> profile(
-      ProfileSyncServiceMock::MakeSignedInTestingProfile());
-  NiceMock<ProfileSyncServiceMock> service(profile.get());
-  DictionaryValue strings;
-
-  // Will be released when the dictionary is destroyed
-  string16 str(ASCIIToUTF16("none"));
-
-  browser_sync::SyncBackendHost::Status status;
-
-  EXPECT_CALL(service, HasSyncSetupCompleted())
-              .WillOnce(Return(true));
-  EXPECT_CALL(service, QueryDetailedSyncStatus())
-              .WillOnce(Return(status));
-
-  EXPECT_CALL(service, HasUnrecoverableError())
-              .WillRepeatedly(Return(true));
-
-  EXPECT_CALL(service, GetLastSyncedTimeString())
-              .WillOnce(Return(str));
-
-  sync_ui_util::ConstructAboutInformation(&service, &strings);
-
-  EXPECT_TRUE(strings.HasKey("unrecoverable_error_detected"));
-}
 
 // Test that GetStatusLabelsForSyncGlobalError returns an error if a
 // passphrase is required.
 TEST(SyncUIUtilTest, PassphraseGlobalError) {
   MessageLoopForUI message_loop;
   content::TestBrowserThread ui_thread(BrowserThread::UI, &message_loop);
   scoped_ptr<Profile> profile(
       ProfileSyncServiceMock::MakeSignedInTestingProfile());
   NiceMock<ProfileSyncServiceMock> service(profile.get());
   FakeSigninManager signin;
   browser_sync::SyncBackendHost::Status status;
-  EXPECT_CALL(service, QueryDetailedSyncStatus())
-              .WillRepeatedly(Return(status));
+  EXPECT_CALL(service, QueryDetailedSyncStatus(_))
+              .WillRepeatedly(Return(false));
 
   EXPECT_CALL(service, IsPassphraseRequired())
               .WillRepeatedly(Return(true));
   EXPECT_CALL(service, IsPassphraseRequiredForDecryption())
               .WillRepeatedly(Return(true));
   VerifySyncGlobalErrorResult(
       &service, signin, GoogleServiceAuthError::NONE, true, true);
 }
 
 // Test that GetStatusLabelsForSyncGlobalError returns an error if a
 // passphrase is required.
 TEST(SyncUIUtilTest, AuthAndPassphraseGlobalError) {
   MessageLoopForUI message_loop;
   content::TestBrowserThread ui_thread(BrowserThread::UI, &message_loop);
   scoped_ptr<Profile> profile(
       ProfileSyncServiceMock::MakeSignedInTestingProfile());
   NiceMock<ProfileSyncServiceMock> service(profile.get());
   FakeSigninManager signin;
   browser_sync::SyncBackendHost::Status status;
-  EXPECT_CALL(service, QueryDetailedSyncStatus())
-              .WillRepeatedly(Return(status));
+  EXPECT_CALL(service, QueryDetailedSyncStatus(_))
+              .WillRepeatedly(Return(false));
 
   EXPECT_CALL(service, IsPassphraseRequired())
               .WillRepeatedly(Return(true));
   EXPECT_CALL(service, IsPassphraseRequiredForDecryption())
               .WillRepeatedly(Return(true));
   EXPECT_CALL(service, HasSyncSetupCompleted())
               .WillRepeatedly(Return(true));
 
   GoogleServiceAuthError auth_error(
       GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS);
@@ skipping 10 matching lines @@
 // that can be resolved by the user and suppresses errors for conditions that
 // cannot be resolved by the user.
 TEST(SyncUIUtilTest, AuthStateGlobalError) {
   MessageLoopForUI message_loop;
   content::TestBrowserThread ui_thread(BrowserThread::UI, &message_loop);
   scoped_ptr<Profile> profile(
       ProfileSyncServiceMock::MakeSignedInTestingProfile());
   NiceMock<ProfileSyncServiceMock> service(profile.get());
 
   browser_sync::SyncBackendHost::Status status;
-  EXPECT_CALL(service, QueryDetailedSyncStatus())
-              .WillRepeatedly(Return(status));
+  EXPECT_CALL(service, QueryDetailedSyncStatus(_))
+              .WillRepeatedly(Return(false));
 
   struct {
     GoogleServiceAuthError::State error_state;
     bool is_error;
   } table[] = {
     { GoogleServiceAuthError::NONE, false },
     { GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS, true },
     { GoogleServiceAuthError::USER_NOT_SIGNED_UP, true },
     { GoogleServiceAuthError::CONNECTION_FAILED, false },
     { GoogleServiceAuthError::CAPTCHA_REQUIRED, true },
@@ skipping 22 matching lines @@
   // Auth Error object is returned by reference in mock and needs to stay in
   // scope throughout test, so it is owned by calling method. However it is
   // immutable so can only be allocated in this method.
   switch (caseNumber) {
     case STATUS_CASE_SETUP_IN_PROGRESS: {
       EXPECT_CALL(service, HasSyncSetupCompleted())
                   .WillOnce(Return(false));
       EXPECT_CALL(service, FirstSetupInProgress())
                   .WillOnce(Return(true));
       browser_sync::SyncBackendHost::Status status;
-      EXPECT_CALL(service, QueryDetailedSyncStatus())
-                  .WillOnce(Return(status));
+      EXPECT_CALL(service, QueryDetailedSyncStatus(_))
+                  .WillOnce(DoAll(SetArgPointee<0>(status),
+                                  Return(false)));
       *auth_error = new GoogleServiceAuthError(GoogleServiceAuthError::NONE);
       EXPECT_CALL(service, GetAuthError())
                   .WillOnce(ReturnRef(**auth_error));
       EXPECT_CALL(signin, AuthInProgress()).WillRepeatedly(Return(false));
       return;
     }
    case STATUS_CASE_SETUP_ERROR: {
       EXPECT_CALL(service, HasSyncSetupCompleted())
                   .WillOnce(Return(false));
       EXPECT_CALL(service, FirstSetupInProgress())
                   .WillOnce(Return(false));
       EXPECT_CALL(service, HasUnrecoverableError())
                   .WillOnce(Return(true));
       EXPECT_CALL(signin, AuthInProgress()).WillRepeatedly(Return(false));
       browser_sync::SyncBackendHost::Status status;
-      EXPECT_CALL(service, QueryDetailedSyncStatus())
-                  .WillOnce(Return(status));
+      EXPECT_CALL(service, QueryDetailedSyncStatus(_))
+                  .WillOnce(DoAll(SetArgPointee<0>(status),
+                                  Return(false)));
       return;
     }
     case STATUS_CASE_AUTHENTICATING: {
       EXPECT_CALL(service, HasSyncSetupCompleted())
                   .WillOnce(Return(true));
       browser_sync::SyncBackendHost::Status status;
-      EXPECT_CALL(service, QueryDetailedSyncStatus())
-                  .WillOnce(Return(status));
+      EXPECT_CALL(service, QueryDetailedSyncStatus(_))
+                  .WillOnce(DoAll(SetArgPointee<0>(status),
+                                  Return(false)));
       EXPECT_CALL(service, HasUnrecoverableError())
                   .WillOnce(Return(false));
       EXPECT_CALL(signin, AuthInProgress()).WillRepeatedly(Return(true));
       *auth_error = new GoogleServiceAuthError(GoogleServiceAuthError::NONE);
       EXPECT_CALL(service, GetAuthError())
                   .WillOnce(ReturnRef(**auth_error));
       return;
     }
     case STATUS_CASE_AUTH_ERROR: {
       EXPECT_CALL(service, HasSyncSetupCompleted())
                   .WillOnce(Return(true));
       browser_sync::SyncBackendHost::Status status;
-      EXPECT_CALL(service, QueryDetailedSyncStatus())
-                  .WillOnce(Return(status));
+      EXPECT_CALL(service, QueryDetailedSyncStatus(_))
+                  .WillOnce(DoAll(SetArgPointee<0>(status),
+                                  Return(false)));
       *auth_error = new GoogleServiceAuthError(
          GoogleServiceAuthError::SERVICE_UNAVAILABLE);
       EXPECT_CALL(service, HasUnrecoverableError())
                   .WillOnce(Return(false));
       EXPECT_CALL(signin, AuthInProgress()).WillRepeatedly(Return(false));
       EXPECT_CALL(service, GetAuthError())
                   .WillOnce(ReturnRef(**auth_error));
       return;
     }
     case STATUS_CASE_PROTOCOL_ERROR: {
       EXPECT_CALL(service, HasSyncSetupCompleted())
                   .WillOnce(Return(true));
       syncer::SyncProtocolError protocolError;
       protocolError.action = syncer::STOP_AND_RESTART_SYNC;
       browser_sync::SyncBackendHost::Status status;
       status.sync_protocol_error = protocolError;
-      EXPECT_CALL(service, QueryDetailedSyncStatus())
-                  .WillOnce(Return(status));
+      EXPECT_CALL(service, QueryDetailedSyncStatus(_))
+                  .WillOnce(DoAll(SetArgPointee<0>(status),
+                                  Return(false)));
       *auth_error = new GoogleServiceAuthError(GoogleServiceAuthError::NONE);
       EXPECT_CALL(service, GetAuthError())
                   .WillOnce(ReturnRef(**auth_error));
       EXPECT_CALL(signin, AuthInProgress()).WillRepeatedly(Return(false));
       EXPECT_CALL(service, HasUnrecoverableError())
                   .WillOnce(Return(false));
       return;
     }
     case STATUS_CASE_PASSPHRASE_ERROR: {
       EXPECT_CALL(service, HasSyncSetupCompleted())
                   .WillOnce(Return(true));
       browser_sync::SyncBackendHost::Status status;
-      EXPECT_CALL(service, QueryDetailedSyncStatus())
-                  .WillOnce(Return(status));
+      EXPECT_CALL(service, QueryDetailedSyncStatus(_))
+                  .WillOnce(DoAll(SetArgPointee<0>(status),
+                                  Return(false)));
       *auth_error = new GoogleServiceAuthError(GoogleServiceAuthError::NONE);
       EXPECT_CALL(service, GetAuthError())
                   .WillOnce(ReturnRef(**auth_error));
       EXPECT_CALL(service, HasUnrecoverableError())
                   .WillOnce(Return(false));
       EXPECT_CALL(signin, AuthInProgress()).WillRepeatedly(Return(false));
       EXPECT_CALL(service, IsPassphraseRequired())
                   .WillOnce(Return(true));
       EXPECT_CALL(service, IsPassphraseRequiredForDecryption())
                   .WillOnce(Return(true));
       return;
     }
     case STATUS_CASE_SYNCED: {
       EXPECT_CALL(service, HasSyncSetupCompleted())
               .WillOnce(Return(true));
       browser_sync::SyncBackendHost::Status status;
-      EXPECT_CALL(service, QueryDetailedSyncStatus())
-                  .WillOnce(Return(status));
+      EXPECT_CALL(service, QueryDetailedSyncStatus(_))
+                  .WillOnce(DoAll(SetArgPointee<0>(status),
+                                  Return(false)));
       *auth_error = new GoogleServiceAuthError(GoogleServiceAuthError::NONE);
       EXPECT_CALL(service, GetAuthError())
                   .WillOnce(ReturnRef(**auth_error));
       EXPECT_CALL(signin, AuthInProgress()).WillRepeatedly(Return(false));
       EXPECT_CALL(service, HasUnrecoverableError())
                   .WillOnce(Return(false));
       EXPECT_CALL(service, IsPassphraseRequired())
                   .WillOnce(Return(false));
       return;
     }
@@ skipping 53 matching lines @@
     // Ensures a search for string 'href' (found in links, not a string to be
     // found in an English language message) fails when links are excluded from
     // the status label.
     EXPECT_EQ(status_label.find(string16(ASCIIToUTF16("href"))),
               string16::npos);
     if (auth_error) {
       delete auth_error;
     }
   }
 }