sync: Track validity of about:sync fields

chrome/browser/sync/sync_global_error_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/sync_global_error.h"
 
 #include "base/basictypes.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/signin/signin_manager.h"
@@ skipping 127 matching lines @@
   scoped_ptr<Profile> profile(
       ProfileSyncServiceMock::MakeSignedInTestingProfile());
   NiceMock<ProfileSyncServiceMock> service(profile.get());
   SigninManager* signin = SigninManagerFactory::GetForProfile(profile.get());
   LoginUIServiceMock* login_ui_service = static_cast<LoginUIServiceMock*>(
       LoginUIServiceFactory::GetInstance()->SetTestingFactoryAndUse(
           profile.get(), BuildMockLoginUIService));
   SyncGlobalError error(&service, signin);
 
   browser_sync::SyncBackendHost::Status status;
-  EXPECT_CALL(service, QueryDetailedSyncStatus())
-              .WillRepeatedly(Return(status));
+  EXPECT_CALL(service, QueryDetailedSyncStatus(_))
+              .WillRepeatedly(Return(false));
 
   EXPECT_CALL(service, IsPassphraseRequired())
               .WillRepeatedly(Return(true));
   EXPECT_CALL(service, IsPassphraseRequiredForDecryption())
               .WillRepeatedly(Return(true));
   VerifySyncGlobalErrorResult(
       &service, login_ui_service, browser(), &error,
       GoogleServiceAuthError::NONE, true, true);
 }
 
 // Test that SyncGlobalError shows an error for conditions that can be resolved
 // by the user and suppresses errors for conditions that  cannot be resolved by
 // the user.
 TEST_F(SyncGlobalErrorTest, AuthStateGlobalError) {
   scoped_ptr<Profile> profile(
       ProfileSyncServiceMock::MakeSignedInTestingProfile());
   NiceMock<ProfileSyncServiceMock> service(profile.get());
   SigninManager* signin = SigninManagerFactory::GetForProfile(profile.get());
   LoginUIServiceMock* login_ui_service = static_cast<LoginUIServiceMock*>(
       LoginUIServiceFactory::GetInstance()->SetTestingFactoryAndUse(
           profile.get(), BuildMockLoginUIService));
   SyncGlobalError error(&service, signin);
 
   browser_sync::SyncBackendHost::Status status;
-  EXPECT_CALL(service, QueryDetailedSyncStatus())
-              .WillRepeatedly(Return(status));
+  EXPECT_CALL(service, QueryDetailedSyncStatus(_))
+              .WillRepeatedly(Return(false));
 
   struct {
     GoogleServiceAuthError::State error_state;
     bool is_error;
   } table[] = {
     { GoogleServiceAuthError::NONE, false },
     { GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS, true },
     { GoogleServiceAuthError::USER_NOT_SIGNED_UP, true },
     { GoogleServiceAuthError::CONNECTION_FAILED, false },
     { GoogleServiceAuthError::CAPTCHA_REQUIRED, true },
     { GoogleServiceAuthError::ACCOUNT_DELETED, true },
     { GoogleServiceAuthError::ACCOUNT_DISABLED, true },
     { GoogleServiceAuthError::SERVICE_UNAVAILABLE, true },
     { GoogleServiceAuthError::TWO_FACTOR, true },
     { GoogleServiceAuthError::REQUEST_CANCELED, true },
     { GoogleServiceAuthError::HOSTED_NOT_ALLOWED, true },
   };
 
   for (size_t i = 0; i < sizeof(table)/sizeof(*table); ++i) {
     VerifySyncGlobalErrorResult(&service, login_ui_service, browser(), &error,
                                 table[i].error_state, true, table[i].is_error);
     VerifySyncGlobalErrorResult(&service, login_ui_service, browser(), &error,
                                 table[i].error_state, false, false);
   }
 }