[Sync] Move ModelType and related classes to 'syncer' namespace

[Sync] Move ModelType and related classes to 'syncer' namespace

Previously they were in 'syncer::syncable'.

Also remove aliases to those classes from 'syncable'.

BUG=128060
TEST=
TBR=pkasting@chromium.org,jhawkins@chromium.org,

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145399

[akalin, 2012-07-03 08:45:36]

+rlarocque for review (sorry)

I'll TBR owners after you LGTM

[rlarocque, 2012-07-03 17:51:24]

I see some minor issues, but no practical way of addressing them.  This is
probably the best we could do.

LGTM.

http://codereview.chromium.org/10696087/diff/2001/chrome/browser/sync/profile...
File chrome/browser/sync/profile_sync_service_password_unittest.cc (left):

http://codereview.chromium.org/10696087/diff/2001/chrome/browser/sync/profile...
chrome/browser/sync/profile_sync_service_password_unittest.cc:184:
syncable::ModelTypeSet preferred_types =
nit: put this one one line.

This probably isn't the only instance of this.  I have no idea how to automate a
search for it, and I won't be able to catch them all by reading, so I guess
we'll just have to live with it.

http://codereview.chromium.org/10696087/diff/2001/sync/engine/syncer_util.cc
File sync/engine/syncer_util.cc (right):

http://codereview.chromium.org/10696087/diff/2001/sync/engine/syncer_util.cc#...
sync/engine/syncer_util.cc:253: <<
syncer::ModelTypeToString(entry->GetServerModelType())
It's not necessary to explicitly specify the namespace here (or anywhere else in
this file).  

I understand that trying to remove all instances of this would be a lot of work.
 I guess we'll just leave it like this for now?

[akalin, 2012-07-03 21:47:08]

committing soon

http://codereview.chromium.org/10696087/diff/2001/chrome/browser/sync/profile...
File chrome/browser/sync/profile_sync_service_password_unittest.cc (left):

http://codereview.chromium.org/10696087/diff/2001/chrome/browser/sync/profile...
chrome/browser/sync/profile_sync_service_password_unittest.cc:184:
syncable::ModelTypeSet preferred_types =
On 2012/07/03 17:51:25, rlarocque wrote:
> nit: put this one one line.
> 
> This probably isn't the only instance of this.  I have no idea how to automate
a
> search for it, and I won't be able to catch them all by reading, so I guess
> we'll just have to live with it.

I went through the CL and cleaned up as much as I could.  There's probably some
still left, but I think it's okay.  Sometimes it's more readable to put it on
two lines even if it technically fits on one.

Also cleaned up a few other indent mistakes I saw.

http://codereview.chromium.org/10696087/diff/2001/sync/engine/syncer_util.cc
File sync/engine/syncer_util.cc (right):

http://codereview.chromium.org/10696087/diff/2001/sync/engine/syncer_util.cc#...
sync/engine/syncer_util.cc:253: <<
syncer::ModelTypeToString(entry->GetServerModelType())
On 2012/07/03 17:51:25, rlarocque wrote:
> It's not necessary to explicitly specify the namespace here (or anywhere else
in
> this file).  
> 
> I understand that trying to remove all instances of this would be a lot of
work.
>  I guess we'll just leave it like this for now?

Yeah.  I'm planning to clean it all up once everything is in 'syncer'. (As then
I can just remove all instances of 'syncer::' in sync/.)

[commit-bot: I haz the power, 2012-07-03 21:47:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10696087/5002

[commit-bot: I haz the power, 2012-07-03 21:51:10]

Presubmit check for 10696087-5002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
You might be calling functions intended only for testing from
production code.  It is OK to ignore this warning if you know what
you are doing, as the heuristics used to detect the situation are
not perfect.  The commit queue will not block on this warning.
Email joi@chromium.org if you have questions.
  sync/syncable/nigori_util.cc:93
    bool VerifyDataTypeEncryptionForTest(

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/search_engines
    chrome/browser/ui/webui/ntp
    chrome/browser/ui/webui
    chrome/browser/ui/webui/sync_promo

Presubmit checks took 17.6s to calculate.

[commit-bot: I haz the power, 2012-07-03 22:20:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10696087/5002