Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 10696063: chromeos: Remove print statements from tools/cros.DEPS/DEPS (Closed)

Created:
8 years, 5 months ago by satorux1
Modified:
8 years, 5 months ago
Reviewers:
nsylvain
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

chromeos: Remove print statements from tools/cros.DEPS/DEPS The print statements caused a syntax error in the DEPS file of the official builds. The DEPS file for the official builds seems be generated with some script by merging DEPS files, and it resulted in a syntax error in the generated DEPS file: starting gclient ... Error: There is a syntax error in C:\b\build\slave\win\build\chrome-official\DEPS Line #1, character 6: "ERROR: src/tools/cros.DEPS/DEPS has been merged into src/DEPS." BUG=108090 TEST=run gclient sync locally with the empty DEPS file in .gclient file, and confirm there was no error. NOTRY=true TBR=nsylvain Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145085

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tools/cros.DEPS/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nsylvain
lgtm
8 years, 5 months ago (2012-06-30 17:25:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/10696063/1
8 years, 5 months ago (2012-06-30 17:28:09 UTC) #2
commit-bot: I haz the power
8 years, 5 months ago (2012-06-30 18:10:06 UTC) #3
Change committed as 145085

Powered by Google App Engine
This is Rietveld 408576698