Issue 10696062: Revert 145000 - chromeos: Merge tools/cros.DEPS/DEPS into the main DEPS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10696062: Revert 145000 - chromeos: Merge tools/cros.DEPS/DEPS into the main DEPS. (Closed)

Created:
8 years, 5 months ago by dharani

Modified:
8 years, 5 months ago

Reviewers:
satorux1

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1191/src/

Visibility:
Public.

More Reviews

Description

Revert 145000 - chromeos: Merge tools/cros.DEPS/DEPS into the main DEPS. This is to simplify setup needed to work on Chrome for Chrome OS. system_api.git is Chrome OS only, but pretty small (324KB including files in .git directory). Note that the previous attempt (crrev.com/116766) was reverted as deps2git didn't support git dependencies at that time, but the issue is now fixed (crbug.com/109475) BUG=108090 TEST=the error message is shown while gclient sync as intended if .gclient contains the deprecated cros_deps rule. Review URL: https://chromiumcodereview.appspot.com/10696055 TBR=satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145069

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -9 lines)			Patch
M	DEPS	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	tools/cros.DEPS/DEPS	View	1 chunk	+13 lines, -3 lines	0 comments	Download
A +	tools/cros.DEPS/README	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

satorux1

8 years, 5 months ago (2012-06-30 16:26:07 UTC) #2

Please add some explanation why was this reverted in the patch description...

Expand Messages | Collapse Messages