Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 10696058: Ignore Unicode BiDi control characters in missing glyphs check in RenderTextWin. (Closed)

Created:
8 years, 5 months ago by Alexei Svitkine (slow)
Modified:
8 years, 5 months ago
Reviewers:
msw, xji
CC:
chromium-reviews
Visibility:
Public.

Description

Ignore Unicode BiDi control characters in missing glyphs check in RenderTextWin. BUG=135160 TEST=Open chrome.exe with --lang=he and bring up context menu. There should be no lag opening t. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145046

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M ui/gfx/render_text_win.cc View 2 chunks +13 lines, -1 line 4 comments Download

Messages

Total messages: 6 (0 generated)
Alexei Svitkine (slow)
8 years, 5 months ago (2012-06-29 23:03:10 UTC) #1
xji
lgtm (with a question). http://codereview.chromium.org/10696058/diff/1/ui/gfx/render_text_win.cc File ui/gfx/render_text_win.cc (right): http://codereview.chromium.org/10696058/diff/1/ui/gfx/render_text_win.cc#newcode859 ui/gfx/render_text_win.cc:859: !IsUnicodeBidiControlCharacter(run_text[char_index])) { so, it always ...
8 years, 5 months ago (2012-06-29 23:13:19 UTC) #2
msw
LGTM too, with an optional suggestion/question on limiting by OS. http://codereview.chromium.org/10696058/diff/1/ui/gfx/render_text_win.cc File ui/gfx/render_text_win.cc (right): http://codereview.chromium.org/10696058/diff/1/ui/gfx/render_text_win.cc#newcode852 ...
8 years, 5 months ago (2012-06-29 23:17:24 UTC) #3
Alexei Svitkine (slow)
http://codereview.chromium.org/10696058/diff/1/ui/gfx/render_text_win.cc File ui/gfx/render_text_win.cc (right): http://codereview.chromium.org/10696058/diff/1/ui/gfx/render_text_win.cc#newcode852 ui/gfx/render_text_win.cc:852: // Windows Vista sometimes returns glyphs equal to wgBlank ...
8 years, 5 months ago (2012-06-29 23:26:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10696058/1
8 years, 5 months ago (2012-06-29 23:26:24 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-06-30 00:57:24 UTC) #6
Change committed as 145046

Powered by Google App Engine
This is Rietveld 408576698