Issue 10696042: [gtk] add oauth2 scopes zippies in extension install dialog

Issue 10696042: [gtk] add oauth2 scopes zippies in extension install dialog (Closed)

Created:
8 years, 5 months ago by Evan Stade

Modified:
8 years, 5 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[gtk] add oauth2 scopes zippies in extension install dialog BUG=130206 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145225

Patch Set 3 : i18n #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -18 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+3 lines, -1 line	1 comment	Download
M	chrome/browser/extensions/extension_install_prompt.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_prompt.cc	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc	View	1 2	7 chunks	+102 lines, -17 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

http://codereview.chromium.org/10696042/diff/4001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/10696042/diff/4001/chrome/app/generated_resources.grd#newcode4309 chrome/app/generated_resources.grd:4309: + The app wants these scopes: this string is ...

8 years, 5 months ago (2012-06-29 22:47:47 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10696042/4001

8 years, 5 months ago (2012-07-02 18:32:36 UTC) #4

commit-bot: I haz the power

8 years, 5 months ago (2012-07-02 19:15:57 UTC) #5

Try job failure for 10696042-4001 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Expand Messages | Collapse Messages