Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Unified Diff: lib/dom/scripts/systemnative.py

Issue 10696035: Extract common logic for element factory constructors generation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: . Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/dom/scripts/systemhtml.py ('k') | lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/dom/scripts/systemnative.py
diff --git a/lib/dom/scripts/systemnative.py b/lib/dom/scripts/systemnative.py
index f2933ccb7314b99e6c5e9dd61819d174df0ede4e..dd57e041a33c13d8c00bcba19a93105d097e6ad8 100644
--- a/lib/dom/scripts/systemnative.py
+++ b/lib/dom/scripts/systemnative.py
@@ -190,6 +190,9 @@ class NativeImplementationGenerator(systembase.BaseGenerator):
def HasImplementation(self):
return not IsPureInterface(self._interface.id)
+ def ImplementationClassName(self):
+ return self._ImplClassName(self._interface.id)
+
def FilePathForDartImplementation(self):
return os.path.join(self._system._output_dir, 'dart',
'%sImplementation.dart' % self._interface.id)
@@ -222,9 +225,6 @@ class NativeImplementationGenerator(systembase.BaseGenerator):
def _GenerateConstructors(self):
html_interface_name = self._HTMLInterfaceName(self._interface.id)
- infos = HtmlElementConstructorInfos(html_interface_name)
- if infos:
- self._EmitHtmlElementFactoryConstructors(infos, html_interface_name)
if not self._IsConstructable():
return
@@ -322,14 +322,6 @@ class NativeImplementationGenerator(systembase.BaseGenerator):
raises_exceptions=raises_exceptions,
runtime_check=runtime_check)
- def _EmitHtmlElementFactoryConstructors(self, infos, html_interface_name):
- EmitHtmlElementFactoryConstructors(
- self._system._EmitterForFactoryProviderBody(
- infos[0].factory_provider_name),
- infos,
- html_interface_name,
- html_interface_name)
-
def _GenerateEvents(self):
if self._interface.id == 'DocumentFragment':
# Interface DocumentFragment extends Element in dart:html but this fact
« no previous file with comments | « lib/dom/scripts/systemhtml.py ('k') | lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698