Extract common logic for element factory constructors generation.

lib/dom/scripts/systemhtml.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the system to generate
 Dart:html APIs from the IDL database."""
 
 import emitter
 
@@ skipping 892 matching lines @@
         DOMNAME=self._interface.doc_js_name)
 
     for constructor_info in constructors:
       self._members_emitter.Emit(
           '\n'
           '  $CTOR($PARAMS);\n',
           CTOR=self._shared.DartType(constructor_info.ConstructorFullName()),
           PARAMS=constructor_info.ParametersInterfaceDeclaration(
                      self._shared.DartType));
 
+    if infos:
+      EmitHtmlElementFactoryConstructors(
+          self._system._backend._EmitterForFactoryProviderBody(
+              infos[0].factory_provider_name),
+          infos,
+          self._html_interface_name,
+          self._backend.FactoryConstructorElementClassName())
+
     element_type = MaybeTypedArrayElementTypeInHierarchy(
         self._interface, self._system._database)
     if element_type:
       self._members_emitter.Emit(
           '\n'
           '  $CTOR(int length);\n'
           '\n'
           '  $CTOR.fromList(List<$TYPE> list);\n'
           '\n'
           '  $CTOR.fromBuffer(ArrayBuffer buffer,'
@@ skipping 117 matching lines @@
   """
 
   def __init__(self, system, interface, template, dart_code,
       shared):
     super(HtmlFrogClassGenerator, self).__init__(
         system, interface, template, dart_code)
     self._shared = shared
     self._html_interface_name = self._shared._HTMLInterfaceName(
         self._interface.id)
 
+  def FactoryConstructorElementClassName(self):

[Anton Muhin, 2012/06/28 13:24:23]

too long chain of nouns and I cannot decipher it, any better name.  What's the
semantics of this method?

[podivilov, 2012/06/29 13:53:39]

Previously it was interface name in Dartium and implementation name in dart2js.
Now we can put implementation name in both backends. See new version.

+    return self._ImplClassName(self._html_interface_name)
+
   def _ImplClassName(self, type_name):
     return self._shared._ImplClassName(type_name)
 
   def _NarrowToImplementationType(self, type_name):
     if self._ShouldNarrowToImplementationType(type_name):
       return self._ImplClassName(self._shared.DartType(type_name))
     return self._shared.DartType(type_name)
 
   def StartInterface(self):
     interface = self._interface
@@ skipping 34 matching lines @@
         NATIVESPEC=' native "' + native_spec + '"')
     if self._members_emitter == None:
       raise Exception("Class %s doesn't use the $!MEMBERS variable" %
                       self._class_name)
 
     # Emit a factory provider class for the constructor.
     constructor_info = AnalyzeConstructor(interface)
     if constructor_info:
       self._EmitFactoryProvider(constructor_info)
 
-    infos = HtmlElementConstructorInfos(self._html_interface_name)
-    if infos:
-      self._EmitHtmlElementFactoryConstructors(infos)
-
     emit_events, events = self._shared.GetEventAttributes(self._interface)
     if not emit_events:
       return
     elif events:
       self.AddEventAttributes(events)
     else:
       parent_events_class = self._shared.GetParentEventsClass(self._interface)
       self._EmitEventGetter('_' + parent_events_class + 'Impl')
 
     for merged_interface in _merged_html_interfaces:
@@ skipping 10 matching lines @@
     factory_provider = '_' + self._html_interface_name + 'FactoryProvider'
     emitter = self._system._ImplFileEmitter(factory_provider)
     emitter.Emit(
         template,
         FACTORYPROVIDER=factory_provider,
         CONSTRUCTOR=self._html_interface_name,
         PARAMETERS=constructor_info.ParametersImplementationDeclaration(),
         NAMED_CONSTRUCTOR=constructor_info.name or self._html_interface_name,
         ARGUMENTS=constructor_info.ParametersAsArgumentList())
 
-  def _EmitHtmlElementFactoryConstructors(self, infos):
-    EmitHtmlElementFactoryConstructors(
-        self._system._EmitterForFactoryProviderBody(
-            infos[0].factory_provider_name),
-        infos,
-        self._html_interface_name, self._class_name)
-
   def AddIndexer(self, element_type):
     """Adds all the methods required to complete implementation of List."""
     # We would like to simply inherit the implementation of everything except
     # get length(), [], and maybe []=.  It is possible to extend from a base
     # array implementation class only when there is no other implementation
     # inheritance.  There might be no implementation inheritance other than
     # DOMBaseWrapper for many classes, but there might be some where the
     # array-ness is introduced by a non-root interface:
     #
     #   interface Y extends X, List<T> ...
@@ skipping 266 matching lines @@
             Collect(database.GetInterface(parent.type.id),
                     seen, collected)
 
   inheritance_closure = {}
   for interface in database.GetInterfaces():
     seen = set()
     collected = []
     Collect(interface, seen, collected)
     inheritance_closure[interface.id] = collected
   return inheritance_closure