Share JSON schema constants.

chrome/browser/policy/policy_loader_win.cc

Index: chrome/browser/policy/policy_loader_win.cc
diff --git a/chrome/browser/policy/policy_loader_win.cc b/chrome/browser/policy/policy_loader_win.cc
index 36a44fea38450e53e1a55832ad4f4d7e2a503c2f..728c3e80117646f251ec53f1ee6c5811cb355c71 100644
--- a/chrome/browser/policy/policy_loader_win.cc
+++ b/chrome/browser/policy/policy_loader_win.cc
@@ -24,11 +24,13 @@
 #include "base/win/registry.h"
 #include "chrome/browser/policy/policy_bundle.h"
 #include "chrome/browser/policy/policy_map.h"
+#include "chrome/common/json_schema_constants.h"
 #include "policy/policy_constants.h"
 
 using base::win::RegKey;
 using base::win::RegistryKeyIterator;
 using base::win::RegistryValueIterator;
+using namespace json_schema_constants;

[Aaron Boodman, 2012/08/10 19:30:23]

If you end up sticking with the approach you have:

We don't typically include entire namespace this way because it makes it hard to
find where symbols come from.

Instead, how about:

namespace json_schema = json_schema_constants. Or just bite the bullet and type
it out each time :)

[Joao da Silva, 2012/09/05 14:03:29]

Just went for this one. It's a bit extra typing but still better than typing the
full JSONSchemaValidator:: or json_schema_constants::. wdyt?

 using namespace policy::registry_constants;
 
 namespace policy {
@@ -39,10 +41,6 @@ namespace registry_constants {
   const wchar_t kMandatory[] = L"policy";
   const wchar_t kRecommended[] = L"recommended";
   const wchar_t kSchema[] = L"schema";
-  const char kType[] = "type";
-  const char kProperties[] = "properties";
-  const char kAdditionalProperties[] = "additionalProperties";
-  const char kItems[] = "items";
 }  // namespace registry_constants
 
 namespace {