Implement a 2-pass heap verification algorithm.

runtime/vm/heap.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_HEAP_H_
 #define VM_HEAP_H_
 
 #include "platform/assert.h"
 #include "vm/allocation.h"
 #include "vm/flags.h"
 #include "vm/globals.h"
 #include "vm/pages.h"
 #include "vm/scavenger.h"
 
 namespace dart {
 
 // Forward declarations.
 class Isolate;
 class ObjectPointerVisitor;
+class ObjectSet;
 class VirtualMemory;
 
 DECLARE_FLAG(bool, verbose_gc);
 DECLARE_FLAG(bool, verify_before_gc);
 DECLARE_FLAG(bool, verify_after_gc);
 DECLARE_FLAG(bool, gc_at_alloc);
 
 class Heap {
  public:
   enum Space {
@@ skipping 43 matching lines @@
         UNREACHABLE();
     }
     return 0;
   }
 
   // Heap contains the specified address.
   bool Contains(uword addr) const;
   bool CodeContains(uword addr) const;
   bool StubCodeContains(uword addr) const;
 
+  void VisitObjects(ObjectVisitor* visitor);

[Ivan Posva, 2012/06/29 22:20:41]

It is unclear why these are named different. We already have IterateXObjects and
IterateXPointers. We should move these down next to them and name them
consistently.

[cshapiro, 2012/07/10 21:48:17]

VisitObjects -> IterateObjects
VisitObjectPointers -> IteratePointers

Each signature is above the space-specific iterators for the sake of
consistency.

Done.

+
+  void VisitObjectPointers(ObjectPointerVisitor* visitor);
+
   // Visit all pointers in the space.
   void IterateNewPointers(ObjectPointerVisitor* visitor);
   void IterateOldPointers(ObjectPointerVisitor* visitor);
   void IterateCodePointers(ObjectPointerVisitor* visitor);
 
   // Visit all object in the space.
   void IterateNewObjects(ObjectVisitor* visitor);
   void IterateOldObjects(ObjectVisitor* visitor);
   void IterateCodeObjects(ObjectVisitor* visitor);
 
@@ skipping 22 matching lines @@
 
   // Initialize the heap and register it with the isolate.
   static void Init(Isolate* isolate);
 
   // Verify that all pointers in the heap point to the heap.
   bool Verify() const;
 
   // Print heap sizes.
   void PrintSizes() const;
 
+  void StartEndAddress(uword* start, uword* end) const;
+
+  ObjectSet* GetAllocatedObjects() const;
+
   // Generates a profile of the current and VM isolate heaps.
   void Profile(Dart_HeapProfileWriteCallback callback, void* stream) const;
 
  private:
   Heap();
 
   uword AllocateNew(intptr_t size);
   uword AllocateOld(intptr_t size);
   uword AllocateCode(PageSpace* space, intptr_t size);
 
@@ skipping 19 matching lines @@
  public:
   NoGCScope() {}
  private:
   DISALLOW_COPY_AND_ASSIGN(NoGCScope);
 };
 #endif  // defined(DEBUG)
 
 }  // namespace dart
 
 #endif  // VM_HEAP_H_