Implement a 2-pass heap verification algorithm.

runtime/vm/pages.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/pages.h"
 
 #include "platform/assert.h"
 #include "vm/gc_marker.h"
 #include "vm/gc_sweeper.h"
 #include "vm/object.h"
@@ skipping 248 matching lines @@
   while (page != NULL) {
     if (page->Contains(addr)) {
       return true;
     }
     page = page->next();
   }
   return false;
 }
 
 
+void PageSpace::StartEndAddress(uword* start, uword* end) const {
+  ASSERT(pages_ != NULL || large_pages_ != NULL);
+  *start = static_cast<uword>(~0);
+  *end = 0;
+  for (HeapPage* page = pages_; page != NULL; page = page->next()) {
+    *start = Utils::Minimum(*start, page->start());
+    *end = Utils::Maximum(*end, page->end());
+  }
+  for (HeapPage* page = large_pages_; page != NULL; page = page->next()) {
+    *start = Utils::Minimum(*start, page->start());
+    *end = Utils::Maximum(*end, page->end());
+  }
+  ASSERT(*start != static_cast<uword>(~0));
+  ASSERT(*end != 0);
+}
+
+
 void PageSpace::VisitObjects(ObjectVisitor* visitor) const {
   HeapPage* page = pages_;
   while (page != NULL) {
     page->VisitObjects(visitor);
     page = page->next();
   }
 
   page = large_pages_;
   while (page != NULL) {
     page->VisitObjects(visitor);
@@ skipping 41 matching lines @@
 
 
 void PageSpace::MarkSweep(bool invoke_api_callbacks) {
   // MarkSweep is not reentrant. Make sure that is the case.
   ASSERT(!sweeping_);
   sweeping_ = true;
   Isolate* isolate = Isolate::Current();
   NoHandleScope no_handles(isolate);
 
   if (FLAG_verify_before_gc) {
-    OS::PrintErr("Verifying before MarkSweep... ");
+    OS::PrintErr("Verifying before MarkSweep...");
     heap_->Verify();
     OS::PrintErr(" done.\n");
   }
 
   Timer timer(true, "MarkSweep");
   timer.Start();
   int64_t start = OS::GetCurrentTimeMillis();
 
   // Mark all reachable old-gen objects.
   GCMarker marker(heap_);
@@ skipping 51 matching lines @@
     const intptr_t KB2 = KB / 2;
     OS::PrintErr("Mark-Sweep[%d]: %lldus (%dK -> %dK, %dK)\n",
                  count_,
                  timer.TotalElapsedTime(),
                  (in_use_before + (KB2)) / KB,
                  (in_use + (KB2)) / KB,
                  (capacity_ + KB2) / KB);
   }
 
   if (FLAG_verify_after_gc) {
-    OS::PrintErr("Verifying after MarkSweep... ");
+    OS::PrintErr("Verifying after MarkSweep...");
     heap_->Verify();
     OS::PrintErr(" done.\n");
   }
 
   count_++;
   // Done, reset the marker.
   ASSERT(sweeping_);
   sweeping_ = false;
 }
 
@@ skipping 105 matching lines @@
     return 0;
   } else {
     ASSERT(total_time >= gc_time);
     int result= static_cast<int>((static_cast<double>(gc_time) /
                              static_cast<double>(total_time)) * 100);
     return result;
   }
 }
 
 }  // namespace dart