Issue 10696025: Upstream ChildProcessLauncher changes for Android.

Issue 10696025: Upstream ChildProcessLauncher changes for Android. (Closed)

Created:
8 years, 5 months ago by Yaron

Modified:
8 years, 5 months ago

Reviewers:
joth, jam

CC:
chromium-reviews, jochen+watch-content_chromium.org, erikwright (departed), jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Upstream ChildProcessLauncher changes for Android. Includes updates to SandboxedProcess* to support passing multiple FDs to child processes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144801

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : add additional assert and comments #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+285 lines, -226 lines)			Patch
M	base/android/jni_array.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	base/android/jni_array.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	content/app/android/sandboxed_process_service.cc	View		5 chunks	+21 lines, -12 lines	0 comments	Download
M	content/browser/android/sandboxed_process_launcher.h	View		3 chunks	+5 lines, -11 lines	0 comments	Download
M	content/browser/android/sandboxed_process_launcher.cc	View		3 chunks	+18 lines, -10 lines	0 comments	Download
M	content/browser/child_process_launcher.cc	View	1	17 chunks	+83 lines, -18 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/app/LibraryLoader.java	View		3 chunks	+12 lines, -3 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/app/SandboxedProcessService.java	View		8 chunks	+44 lines, -10 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/SandboxedProcessConnection.java	View		10 chunks	+71 lines, -141 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java	View	1 2	6 chunks	+13 lines, -21 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

joth

lgtm http://codereview.chromium.org/10696025/diff/3001/content/public/android/java/src/org/chromium/content/browser/SandboxedProcessConnection.java File content/public/android/java/src/org/chromium/content/browser/SandboxedProcessConnection.java (right): http://codereview.chromium.org/10696025/diff/3001/content/public/android/java/src/org/chromium/content/browser/SandboxedProcessConnection.java#newcode122 content/public/android/java/src/org/chromium/content/browser/SandboxedProcessConnection.java:122: assert !ThreadUtils.runningOnUiThread(); (we'll need to remove this then?)

8 years, 5 months ago (2012-06-28 18:20:46 UTC) #3

Yaron

thanks for the reviews http://codereview.chromium.org/10696025/diff/3001/content/public/android/java/src/org/chromium/content/browser/SandboxedProcessConnection.java File content/public/android/java/src/org/chromium/content/browser/SandboxedProcessConnection.java (right): http://codereview.chromium.org/10696025/diff/3001/content/public/android/java/src/org/chromium/content/browser/SandboxedProcessConnection.java#newcode122 content/public/android/java/src/org/chromium/content/browser/SandboxedProcessConnection.java:122: assert !ThreadUtils.runningOnUiThread(); On 2012/06/28 18:20:46, ...

8 years, 5 months ago (2012-06-28 19:17:35 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10696025/11001

8 years, 5 months ago (2012-06-28 19:17:45 UTC) #5

Change committed as 144801

Expand Messages | Collapse Messages