Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 10696007: Avoid redefining HAVE_ENDIAN_H and HAVE_OFF64_T on Android (Closed)

Created:
8 years, 5 months ago by Steve Block
Modified:
8 years, 5 months ago
Reviewers:
bulach, Stephen White
CC:
chromium-reviews
Visibility:
Public.

Description

Avoid redefining HAVE_ENDIAN_H and HAVE_OFF64_T on Android These are already provided by system/core/include/arch/linux-arm/AndroidConfig.h and cause warnings when redefined. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144465

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M build/common.gypi View 2 chunks +3 lines, -1 line 0 comments Download
M skia/skia.gyp View 4 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Steve Block
8 years, 5 months ago (2012-06-27 13:08:51 UTC) #1
bulach
lgtm
8 years, 5 months ago (2012-06-27 13:48:41 UTC) #2
bulach
(you'll need OWNERS approval for skia/)
8 years, 5 months ago (2012-06-27 13:49:07 UTC) #3
Steve Block
+senorblanco for OWNERS
8 years, 5 months ago (2012-06-27 13:54:04 UTC) #4
Stephen White
lgtm
8 years, 5 months ago (2012-06-27 14:09:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/10696007/1
8 years, 5 months ago (2012-06-27 14:10:37 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-06-27 16:10:53 UTC) #7
Change committed as 144465

Powered by Google App Engine
This is Rietveld 408576698