Issue 10696002: ASH: Use virtual screen coordinates in Display::bounds()

Issue 10696002: ASH: Use virtual screen coordinates in Display::bounds() (Closed)

Created:
8 years, 5 months ago by oshima

Modified:
8 years, 5 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use virtual screen coordinates in Display::bounds BUG=123160 TEST=monitor_controller_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144613

Patch Set 4 : sync #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+234 lines, -66 lines)			Patch
M	ash/ash.gyp	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/display/display_controller.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/display/display_controller.cc	View	1 2 3	6 chunks	+47 lines, -9 lines	0 comments	Download
A	ash/display/display_controller_unittest.cc	View	1 2 3	1 chunk	+131 lines, -0 lines	0 comments	Download
M	ash/display/multi_display_manager.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/display/multi_display_manager.cc	View	1 2 3	3 chunks	+4 lines, -4 lines	0 comments	Download
M	ash/display/multi_display_manager_unittest.cc	View	1 2 3	6 chunks	+9 lines, -9 lines	0 comments	Download
M	ash/extended_desktop_unittest.cc	View	1 2 3	2 chunks	+22 lines, -26 lines	0 comments	Download
M	ash/screen_ash.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/shell.cc	View	1 2 3	2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/display_options_handler.cc	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download
M	ui/aura/display_manager.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/display_manager.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/single_display_manager.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/single_display_manager.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/gfx/display.h	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	ui/gfx/display.cc	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

lgtm http://codereview.chromium.org/10696002/diff/1008/ash/ash.gyp File ash/ash.gyp (right): http://codereview.chromium.org/10696002/diff/1008/ash/ash.gyp#newcode390 ash/ash.gyp:390: 'monitor/monitor_controller_unittest.cc', monitor? i thought you renamed all of ...

8 years, 5 months ago (2012-06-27 15:32:52 UTC) #2

oshima

http://codereview.chromium.org/10696002/diff/1008/ash/ash.gyp File ash/ash.gyp (right): http://codereview.chromium.org/10696002/diff/1008/ash/ash.gyp#newcode390 ash/ash.gyp:390: 'monitor/monitor_controller_unittest.cc', On 2012/06/27 15:32:52, Ben Goodger (Google) wrote: > ...

8 years, 5 months ago (2012-06-27 21:00:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10696002/9003

8 years, 5 months ago (2012-06-27 22:33:49 UTC) #4

Change committed as 144613

Expand Messages | Collapse Messages