Issue 10695205: Fix transcendental cache on ARM in optimized code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10695205: Fix transcendental cache on ARM in optimized code. (Closed)

Created:
8 years, 5 months ago by Yang

Modified:
8 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix transcendental cache on ARM in optimized code. R=jkummerow@chromium.org BUG=v8:2234 TEST=regress-2234.js Committed: https://code.google.com/p/v8/source/detail?r=12086

Patch Set 1 #

Total comments: 3

Patch Set 2 : comments addressed. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -23 lines)			Patch
	M	src/arm/code-stubs-arm.cc	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-2234.js	View	1	1 chunk	+9 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 5 months ago (2012-07-16 09:24:09 UTC) #2

LGTM with comments.

https://chromiumcodereview.appspot.com/10695205/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

https://chromiumcodereview.appspot.com/10695205/diff/1/src/arm/code-stubs-arm...
src/arm/code-stubs-arm.cc:3416: __ stm(db_w, sp, cache_entry.bit() | r2.bit() |
r3.bit());
Let's use "__ Push(cache_entry, r2, r3)" instead.

https://chromiumcodereview.appspot.com/10695205/diff/1/src/arm/code-stubs-arm...
src/arm/code-stubs-arm.cc:3422: __ ldm(ia_w, sp, cache_entry.bit() | r2.bit() |
r3.bit());
...and __ Pop(...) here.

https://chromiumcodereview.appspot.com/10695205/diff/1/test/mjsunit/regress/r...
File test/mjsunit/regress/regress-2234.js (right):

https://chromiumcodereview.appspot.com/10695205/diff/1/test/mjsunit/regress/r...
test/mjsunit/regress/regress-2234.js:37: test(i);
I'd add:
if (i == 3) %OptimizeFunctionOnNextCall(test);

and don't forget // Flags: --allow-natives-syntax

Expand Messages | Collapse Messages