Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 10695186: Use SPNEGO mechanism with GSSAPI on Posix (Closed)

Created:
8 years, 5 months ago by asanka
Modified:
8 years, 5 months ago
Reviewers:
cbentzel
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Use SPNEGO mechanism with GSSAPI on Posix BUG=85510 TEST=net_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147465

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -35 lines) Patch
M net/http/http_auth_gssapi_posix.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M net/http/http_auth_gssapi_posix.cc View 1 3 chunks +8 lines, -21 lines 0 comments Download
M net/http/http_auth_gssapi_posix_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M net/http/http_auth_handler_negotiate.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_handler_negotiate_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
asanka
8 years, 5 months ago (2012-07-17 21:56:17 UTC) #1
cbentzel
LGTM http://codereview.chromium.org/10695186/diff/1/net/http/http_auth_gssapi_posix.cc File net/http/http_auth_gssapi_posix.cc (right): http://codereview.chromium.org/10695186/diff/1/net/http/http_auth_gssapi_posix.cc#newcode84 net/http/http_auth_gssapi_posix.cc:84: const_cast<char*>("\x2b\x06\x01\x05\x05\x02") Took me a little while to go ...
8 years, 5 months ago (2012-07-18 18:44:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/10695186/4001
8 years, 5 months ago (2012-07-19 14:43:08 UTC) #3
commit-bot: I haz the power
Try job failure for 10695186-4001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-19 15:39:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/10695186/4001
8 years, 5 months ago (2012-07-19 15:58:54 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-19 17:23:12 UTC) #6
Change committed as 147465

Powered by Google App Engine
This is Rietveld 408576698